Re: [PATCH 2/3 v3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-12-01 Thread Chris Ruehl
On Monday, December 02, 2013 01:10 PM, Peter Chen wrote: If you have a look into the function hw_write() you will see that there is no effect if hw_write(...,sts) is called with sts=0/1, because the mask will cut off all bits beside BIT(29). Yes, it is my careless. I thought sts is

RE: [PATCH 2/3 v3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-12-01 Thread Peter Chen
> > If you have a look into the function hw_write() you will see that there > is no > effect if hw_write(...,sts) is called with sts=0/1, because the mask will > cut > off all bits beside BIT(29). Yes, it is my careless. I thought sts is PORTCS_STS. > I used BIT(29) rather then PORTCS_STS to

Re: [PATCH 2/3 v3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-12-01 Thread Chris Ruehl
Hi On Sunday, December 01, 2013 01:28 AM, Sergei Shtylyov wrote: Hello. On 30-11-2013 7:51, Chris Ruehl wrote: usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag * init the sts flag to 0 (missed) * Set PORTCS_STS only if VUSB_HS_PHY_TYPE > 1 otherwise the register is

Re: [PATCH 2/3 v3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-12-01 Thread Chris Ruehl
On Saturday, November 30, 2013 06:20 PM, Peter Chen wrote: usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag * init the sts flag to 0 (missed) * Set PORTCS_STS only if VUSB_HS_PHY_TYPE> 1 otherwise the register is ReadOnly * Set/Reset correct BIT(28)/BIT(29) for STS

Re: [PATCH 2/3 v3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-12-01 Thread Chris Ruehl
On Saturday, November 30, 2013 06:20 PM, Peter Chen wrote: usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag * init the sts flag to 0 (missed) * Set PORTCS_STS only if VUSB_HS_PHY_TYPE 1 otherwise the register is ReadOnly * Set/Reset correct BIT(28)/BIT(29) for STS

Re: [PATCH 2/3 v3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-12-01 Thread Chris Ruehl
Hi On Sunday, December 01, 2013 01:28 AM, Sergei Shtylyov wrote: Hello. On 30-11-2013 7:51, Chris Ruehl wrote: usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag * init the sts flag to 0 (missed) * Set PORTCS_STS only if VUSB_HS_PHY_TYPE 1 otherwise the register is

RE: [PATCH 2/3 v3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-12-01 Thread Peter Chen
If you have a look into the function hw_write() you will see that there is no effect if hw_write(...,sts) is called with sts=0/1, because the mask will cut off all bits beside BIT(29). Yes, it is my careless. I thought sts is PORTCS_STS. I used BIT(29) rather then PORTCS_STS to make it

Re: [PATCH 2/3 v3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-12-01 Thread Chris Ruehl
On Monday, December 02, 2013 01:10 PM, Peter Chen wrote: If you have a look into the function hw_write() you will see that there is no effect if hw_write(...,sts) is called with sts=0/1, because the mask will cut off all bits beside BIT(29). Yes, it is my careless. I thought sts is

Re: [PATCH 2/3 v3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-11-30 Thread Sergei Shtylyov
Hello. On 30-11-2013 7:51, Chris Ruehl wrote: usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag * init the sts flag to 0 (missed) * Set PORTCS_STS only if VUSB_HS_PHY_TYPE > 1 otherwise the register is ReadOnly * Set/Reset correct BIT(28)/BIT(29) for STS

RE: [PATCH 2/3 v3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-11-30 Thread Peter Chen
> > usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag > > * init the sts flag to 0 (missed) > * Set PORTCS_STS only if VUSB_HS_PHY_TYPE > 1 > otherwise the register is ReadOnly > * Set/Reset correct BIT(28)/BIT(29) for STS > > Signed-off-by: Chris Ruehl > --- >

RE: [PATCH 2/3 v3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-11-30 Thread Peter Chen
usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag * init the sts flag to 0 (missed) * Set PORTCS_STS only if VUSB_HS_PHY_TYPE 1 otherwise the register is ReadOnly * Set/Reset correct BIT(28)/BIT(29) for STS Signed-off-by: Chris Ruehl chris.ru...@gtsys.com.hk

Re: [PATCH 2/3 v3] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2013-11-30 Thread Sergei Shtylyov
Hello. On 30-11-2013 7:51, Chris Ruehl wrote: usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag * init the sts flag to 0 (missed) * Set PORTCS_STS only if VUSB_HS_PHY_TYPE 1 otherwise the register is ReadOnly * Set/Reset correct BIT(28)/BIT(29) for STS