Re: [PATCH 2/4] ARM: ep93xx: keypad: stop using mach/platform.h

2019-04-22 Thread Dmitry Torokhov
On Mon, Apr 15, 2019 at 09:25:24PM +0200, Arnd Bergmann wrote: > We can communicate the clock rate using platform data rather than setting > a flag to use a particular value in the driver, which is cleaner and > avoids the dependency. > > No platform in the kernel currently defines the ep93xx keyp

Re: [PATCH 2/4] ARM: ep93xx: keypad: stop using mach/platform.h

2019-04-15 Thread Guenter Roeck
On Mon, Apr 15, 2019 at 12:56 PM Alexander Sverdlin wrote: > > Hi! > > On 15/04/2019 21:47, Arnd Bergmann wrote: > >>> We can communicate the clock rate using platform data rather than setting > >>> a > >>> flag to use a particular value in the driver, which is cleaner and avoids > >>> the depen

RE: [PATCH 2/4] ARM: ep93xx: keypad: stop using mach/platform.h

2019-04-15 Thread Hartley Sweeten
On Monday, April 15, 2019 12:47 PM, Arnd Bergmann wrote: > On Mon, Apr 15, 2019 at 9:39 PM Hartley Sweeten > wrote: >>> -#define EP93XX_KEYPAD_KDIV (1<<4) /* 1/4 clock or 1/16 clock */ >>> -#define EP93XX_KEYPAD_AUTOREPEAT (1<<5) /* enable key autorepeat */ >>> +#define EP93XX_KEY

Re: [PATCH 2/4] ARM: ep93xx: keypad: stop using mach/platform.h

2019-04-15 Thread Alexander Sverdlin
Hi! On 15/04/2019 21:47, Arnd Bergmann wrote: >>> We can communicate the clock rate using platform data rather than setting a >>> flag to use a particular value in the driver, which is cleaner and avoids >>> the dependency. >>> >>> No platform in the kernel currently defines the ep93xx keypad dev

Re: [PATCH 2/4] ARM: ep93xx: keypad: stop using mach/platform.h

2019-04-15 Thread Arnd Bergmann
On Mon, Apr 15, 2019 at 9:39 PM Hartley Sweeten wrote: > > On Monday, April 15, 2019 12:25 PM, Arnd Bergmann wrote: > > We can communicate the clock rate using platform data rather than setting a > > flag to use a particular value in the driver, which is cleaner and avoids > > the dependency. > >

RE: [PATCH 2/4] ARM: ep93xx: keypad: stop using mach/platform.h

2019-04-15 Thread Hartley Sweeten
On Monday, April 15, 2019 12:25 PM, Arnd Bergmann wrote: > We can communicate the clock rate using platform data rather than setting a > flag to use a particular value in the driver, which is cleaner and avoids the > dependency. > > No platform in the kernel currently defines the ep93xx keypad dev