Re: [PATCH 2/7] ARM: dts: imx6ul: update i.MX 6UltraLite iomux headers

2018-01-09 Thread Dong Aisheng
On Tue, Jan 02, 2018 at 05:42:18PM +0100, Stefan Agner wrote: > From: Fugang Duan > > Update i.MX 6UltraLite IOMUXC pin defines. > > Signed-off-by: Fugang Duan > Signed-off-by: Stefan Agner This is really hard to review. You probably

Re: [PATCH 2/7] ARM: dts: imx6ul: update i.MX 6UltraLite iomux headers

2018-01-09 Thread Dong Aisheng
On Tue, Jan 02, 2018 at 05:42:18PM +0100, Stefan Agner wrote: > From: Fugang Duan > > Update i.MX 6UltraLite IOMUXC pin defines. > > Signed-off-by: Fugang Duan > Signed-off-by: Stefan Agner This is really hard to review. You probably need at least tell how you generated this file. e.g.

RE: [PATCH 2/7] ARM: dts: imx6ul: update i.MX 6UltraLite iomux headers

2018-01-07 Thread Andy Duan
icet...@vger.kernel.org; linux- >ker...@vger.kernel.org; Andy Duan <fugang.d...@nxp.com> >Subject: Re: [PATCH 2/7] ARM: dts: imx6ul: update i.MX 6UltraLite iomux >headers > >On Tue, Jan 02, 2018 at 05:42:18PM +0100, Stefan Agner wrote: >> From: Fugang Duan <fugang.d

RE: [PATCH 2/7] ARM: dts: imx6ul: update i.MX 6UltraLite iomux headers

2018-01-07 Thread Andy Duan
n >Subject: Re: [PATCH 2/7] ARM: dts: imx6ul: update i.MX 6UltraLite iomux >headers > >On Tue, Jan 02, 2018 at 05:42:18PM +0100, Stefan Agner wrote: >> From: Fugang Duan >> >> Update i.MX 6UltraLite IOMUXC pin defines. > >That's obvious reading the diff. The commit

Re: [PATCH 2/7] ARM: dts: imx6ul: update i.MX 6UltraLite iomux headers

2018-01-06 Thread Stefan Agner
On 2018-01-05 17:45, Rob Herring wrote: > On Tue, Jan 02, 2018 at 05:42:18PM +0100, Stefan Agner wrote: >> From: Fugang Duan >> >> Update i.MX 6UltraLite IOMUXC pin defines. > > That's obvious reading the diff. The commit message should tell me why. > They were wrong? I

Re: [PATCH 2/7] ARM: dts: imx6ul: update i.MX 6UltraLite iomux headers

2018-01-06 Thread Stefan Agner
On 2018-01-05 17:45, Rob Herring wrote: > On Tue, Jan 02, 2018 at 05:42:18PM +0100, Stefan Agner wrote: >> From: Fugang Duan >> >> Update i.MX 6UltraLite IOMUXC pin defines. > > That's obvious reading the diff. The commit message should tell me why. > They were wrong? I guess pretty much :-)

Re: [PATCH 2/7] ARM: dts: imx6ul: update i.MX 6UltraLite iomux headers

2018-01-05 Thread Rob Herring
On Tue, Jan 02, 2018 at 05:42:18PM +0100, Stefan Agner wrote: > From: Fugang Duan > > Update i.MX 6UltraLite IOMUXC pin defines. That's obvious reading the diff. The commit message should tell me why. They were wrong? > > Signed-off-by: Fugang Duan

Re: [PATCH 2/7] ARM: dts: imx6ul: update i.MX 6UltraLite iomux headers

2018-01-05 Thread Rob Herring
On Tue, Jan 02, 2018 at 05:42:18PM +0100, Stefan Agner wrote: > From: Fugang Duan > > Update i.MX 6UltraLite IOMUXC pin defines. That's obvious reading the diff. The commit message should tell me why. They were wrong? > > Signed-off-by: Fugang Duan > Signed-off-by: Stefan Agner