RE: [PATCH 3/3] arm64: dts: imx8mp: add mu node

2020-05-19 Thread Aisheng Dong
> From: Fabio Estevam > Sent: Wednesday, May 20, 2020 11:07 AM > > Hi Peng, > > On Wed, May 20, 2020 at 12:01 AM Peng Fan wrote: > > > Nothing specific in i.MX8MP for the mu part, so do we really need add > > "fsl,imx8mp-mu"? > > It is good practice to add a more specific option. > > Let's s

RE: [PATCH 3/3] arm64: dts: imx8mp: add mu node

2020-05-19 Thread Peng Fan
> Subject: Re: [PATCH 3/3] arm64: dts: imx8mp: add mu node > > Hi Peng, > > On Wed, May 20, 2020 at 12:01 AM Peng Fan wrote: > > > Nothing specific in i.MX8MP for the mu part, so do we really need add > > "fsl,imx8mp-mu"? > > It is good practice

Re: [PATCH 3/3] arm64: dts: imx8mp: add mu node

2020-05-19 Thread Fabio Estevam
Hi Peng, On Wed, May 20, 2020 at 12:01 AM Peng Fan wrote: > Nothing specific in i.MX8MP for the mu part, so do we really need > add "fsl,imx8mp-mu"? It is good practice to add a more specific option. Let's say in future a bug is found that affects imx8mp MU, then you could fix the MU driver an

RE: [PATCH 3/3] arm64: dts: imx8mp: add mu node

2020-05-19 Thread Peng Fan
> Subject: Re: [PATCH 3/3] arm64: dts: imx8mp: add mu node > > Hi Peng, > > On Tue, May 19, 2020 at 11:15 PM wrote: > > > + mu: mailbox@30aa { > > + compatible = "fsl,imx6sx-mu"; > > This

Re: [PATCH 3/3] arm64: dts: imx8mp: add mu node

2020-05-19 Thread Fabio Estevam
Hi Peng, On Tue, May 19, 2020 at 11:15 PM wrote: > + mu: mailbox@30aa { > + compatible = "fsl,imx6sx-mu"; This should be better described as: compatible = "fsl,imx8mp-mu", "fsl,imx6sx-mu"; >From Documentation/devicetree/bindings/mailbox/