Re: [PATCH 3/5] usb: gadget: net2280: Pass checkpacth.pl test

2014-05-20 Thread Ricardo Ribalda Delgado
Not for grep... But if this is an issue I have no problem going back to the original. We can spend a whole year just talking about codestyle. On Tue, May 20, 2014 at 10:52 AM, David Laight wrote: > From: Alan Stern > ... >> > -static struct usb_request * >> > -net2280_alloc_request (struct

RE: [PATCH 3/5] usb: gadget: net2280: Pass checkpacth.pl test

2014-05-20 Thread David Laight
From: Alan Stern ... > > -static struct usb_request * > > -net2280_alloc_request (struct usb_ep *_ep, gfp_t gfp_flags) > > +static struct usb_request *net2280_alloc_request(struct usb_ep *_ep, > > + gfp_t gfp_flags) > > What's with the extreme

RE: [PATCH 3/5] usb: gadget: net2280: Pass checkpacth.pl test

2014-05-20 Thread David Laight
From: Alan Stern ... -static struct usb_request * -net2280_alloc_request (struct usb_ep *_ep, gfp_t gfp_flags) +static struct usb_request *net2280_alloc_request(struct usb_ep *_ep, + gfp_t gfp_flags) What's with the extreme indentation

Re: [PATCH 3/5] usb: gadget: net2280: Pass checkpacth.pl test

2014-05-20 Thread Ricardo Ribalda Delgado
Not for grep... But if this is an issue I have no problem going back to the original. We can spend a whole year just talking about codestyle. On Tue, May 20, 2014 at 10:52 AM, David Laight david.lai...@aculab.com wrote: From: Alan Stern ... -static struct usb_request *

Re: [PATCH 3/5] usb: gadget: net2280: Pass checkpacth.pl test

2014-05-19 Thread Alan Stern
On Mon, 19 May 2014, Ricardo Ribalda Delgado wrote: > Fix Code Style using checkpatch.pl criteria > > Signed-off-by: Ricardo Ribalda Delgado Not really necessary, although this doesn't hurt. It's notable that scattered in amongst all the checkpatch-related changes are a few things that

Re: [PATCH 3/5] usb: gadget: net2280: Pass checkpacth.pl test

2014-05-19 Thread Alan Stern
On Mon, 19 May 2014, Ricardo Ribalda Delgado wrote: Fix Code Style using checkpatch.pl criteria Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com Not really necessary, although this doesn't hurt. It's notable that scattered in amongst all the checkpatch-related changes are a