> @@ -1676,31 +1666,6 @@ void __init mpic_init(struct mpic *mpic)
> mpic_err_int_init(mpic, MPIC_FSL_ERR_INT);
> }
>
> -void __init mpic_set_clk_ratio(struct mpic *mpic, u32 clock_ratio)
> -{
> - u32 v;
> -
> - v = mpic_read(mpic->gregs, MPIC_GREG_GLOBAL_CONF_1);
> - v
@@ -1676,31 +1666,6 @@ void __init mpic_init(struct mpic *mpic)
mpic_err_int_init(mpic, MPIC_FSL_ERR_INT);
}
-void __init mpic_set_clk_ratio(struct mpic *mpic, u32 clock_ratio)
-{
- u32 v;
-
- v = mpic_read(mpic-gregs, MPIC_GREG_GLOBAL_CONF_1);
- v =
On Wed, 2015-02-25 at 20:39 -0600, Jia Hongtao-B38951 wrote:
> Hi Scott,
>
> I'm really sorry for leave this patch like a zombie.
> Now I have plan to revisit this patch.
>
> From the previous comments the compile error was fixed.
> But beyond that I have had no plan to update it.
>
> Could you
age-
> From: Wood Scott-B07421
> Sent: Tuesday, February 24, 2015 5:32 AM
> To: Arseny Solokha
> Cc: Michael Ellerman; Benjamin Herrenschmidt; Paul Mackerras; linuxppc-
> d...@lists.ozlabs.org; linux-kernel@vger.kernel.org; Jia Hongtao-B38951
> Subject: Re: [PATCH 4/4] powerp
-
From: Wood Scott-B07421
Sent: Tuesday, February 24, 2015 5:32 AM
To: Arseny Solokha
Cc: Michael Ellerman; Benjamin Herrenschmidt; Paul Mackerras; linuxppc-
d...@lists.ozlabs.org; linux-kernel@vger.kernel.org; Jia Hongtao-B38951
Subject: Re: [PATCH 4/4] powerpc/mpic: remove unused functions
On Wed, 2015-02-25 at 20:39 -0600, Jia Hongtao-B38951 wrote:
Hi Scott,
I'm really sorry for leave this patch like a zombie.
Now I have plan to revisit this patch.
From the previous comments the compile error was fixed.
But beyond that I have had no plan to update it.
Could you please
On Fri, 2015-02-20 at 11:40 +0700, Arseny Solokha wrote:
> > If I just get a patch saying "removed unused foo()", I have to go and dig
> > and
> > find out:
> > - was it recently added and will be used soon?
> > - is it ancient and never used, if so can we work out why, ie. feature X
> >
On Thu, 2015-02-19 at 19:26 +0700, Arseny Solokha wrote:
> + fsl_mpic_primary_get_version() is just a safe wrapper around
> fsl_mpic_get_version() for SMP configurations. While the latter is
> called explicitly for handling PIC initialization and setting up error
> interrupt vector depending on
On Thu, 2015-02-19 at 19:26 +0700, Arseny Solokha wrote:
+ fsl_mpic_primary_get_version() is just a safe wrapper around
fsl_mpic_get_version() for SMP configurations. While the latter is
called explicitly for handling PIC initialization and setting up error
interrupt vector depending on PIC
On Fri, 2015-02-20 at 11:40 +0700, Arseny Solokha wrote:
If I just get a patch saying removed unused foo(), I have to go and dig
and
find out:
- was it recently added and will be used soon?
- is it ancient and never used, if so can we work out why, ie. feature X
never landed
> If I just get a patch saying "removed unused foo()", I have to go and dig and
> find out:
> - was it recently added and will be used soon?
> - is it ancient and never used, if so can we work out why, ie. feature X
> never landed so this code is no longer needed.
> - is it old code that
On Thu, 2015-02-19 at 19:26 +0700, Arseny Solokha wrote:
> > On Mon, 2015-02-16 at 17:56 +0700, Arseny Solokha wrote:
> >> Drop unused fsl_mpic_primary_get_version(), mpic_set_clk_ratio(),
> >> mpic_set_serial_int().
> >
> > I'm always happy to remove unused code, but the interesting question is
> On Mon, 2015-02-16 at 17:56 +0700, Arseny Solokha wrote:
>> Drop unused fsl_mpic_primary_get_version(), mpic_set_clk_ratio(),
>> mpic_set_serial_int().
>
> I'm always happy to remove unused code, but the interesting question is why
> are
> they unused? Please tell me in the changelog.
To being
On Mon, 2015-02-16 at 17:56 +0700, Arseny Solokha wrote:
Drop unused fsl_mpic_primary_get_version(), mpic_set_clk_ratio(),
mpic_set_serial_int().
I'm always happy to remove unused code, but the interesting question is why
are
they unused? Please tell me in the changelog.
To being able to
If I just get a patch saying removed unused foo(), I have to go and dig and
find out:
- was it recently added and will be used soon?
- is it ancient and never used, if so can we work out why, ie. feature X
never landed so this code is no longer needed.
- is it old code that *was*
On Thu, 2015-02-19 at 19:26 +0700, Arseny Solokha wrote:
On Mon, 2015-02-16 at 17:56 +0700, Arseny Solokha wrote:
Drop unused fsl_mpic_primary_get_version(), mpic_set_clk_ratio(),
mpic_set_serial_int().
I'm always happy to remove unused code, but the interesting question is why
are
On Mon, 2015-02-16 at 17:56 +0700, Arseny Solokha wrote:
> Drop unused fsl_mpic_primary_get_version(), mpic_set_clk_ratio(),
> mpic_set_serial_int().
I'm always happy to remove unused code, but the interesting question is why are
they unused? Please tell me in the changelog.
cheers
--
To
On Mon, 2015-02-16 at 17:56 +0700, Arseny Solokha wrote:
Drop unused fsl_mpic_primary_get_version(), mpic_set_clk_ratio(),
mpic_set_serial_int().
I'm always happy to remove unused code, but the interesting question is why are
they unused? Please tell me in the changelog.
cheers
--
To
18 matches
Mail list logo
