Re: [PATCH 5/5] i2c: designware: Switch over to i2c_freq_mode_string()

2021-03-31 Thread Yicong Yang
On 2021/3/31 18:37, Andy Shevchenko wrote: > On Tue, Mar 30, 2021 at 10:19:26PM +0800, Yicong Yang wrote: >> From: Andy Shevchenko >> >> Use generic i2c_freq_mode_string() helper to print chosen bus speed. > > Since it will be a new version (based on Jarkko's comments), I guess you may > add his

Re: [PATCH 5/5] i2c: designware: Switch over to i2c_freq_mode_string()

2021-03-31 Thread Andy Shevchenko
On Tue, Mar 30, 2021 at 10:19:26PM +0800, Yicong Yang wrote: > From: Andy Shevchenko > > Use generic i2c_freq_mode_string() helper to print chosen bus speed. Since it will be a new version (based on Jarkko's comments), I guess you may add his Ack here that he gave against standalone submission

Re: [PATCH 5/5] i2c: designware: Switch over to i2c_freq_mode_string()

2021-03-31 Thread Andy Shevchenko
On Wed, Mar 31, 2021 at 08:53:02AM +, Song Bao Hua (Barry Song) wrote: > > > No, please read the code carefully. > > We can duplicate conditional, but it brings a bit of inconsistency to how > > the counters are printed. > > Thanks for clarification, I am still confused as the original >

RE: [PATCH 5/5] i2c: designware: Switch over to i2c_freq_mode_string()

2021-03-31 Thread Song Bao Hua (Barry Song)
> No, please read the code carefully. > We can duplicate conditional, but it brings a bit of inconsistency to how the > counters are printed. Thanks for clarification, I am still confused as the original code print the real mode based on dev->master_cfg, the new code is printing mode based on

RE: [PATCH 5/5] i2c: designware: Switch over to i2c_freq_mode_string()

2021-03-30 Thread Song Bao Hua (Barry Song)
ernel@vger.kernel.org; > dig...@gmail.com; tred...@nvidia.com; jarkko.nik...@linux.intel.com; > rmk+ker...@armlinux.org.uk; John Garry ; > mika.westerb...@linux.intel.com; Zengtao (B) ; > Linuxarm > Subject: RE: [PATCH 5/5] i2c: designware: Switch over to > i2c_freq_mode_st

RE: [PATCH 5/5] i2c: designware: Switch over to i2c_freq_mode_string()

2021-03-30 Thread Song Bao Hua (Barry Song)
; dig...@gmail.com; tred...@nvidia.com; jarkko.nik...@linux.intel.com; rmk+ker...@armlinux.org.uk; John Garry ; mika.westerb...@linux.intel.com; Zengtao (B) ; Linuxarm Subject: Re: [PATCH 5/5] i2c: designware: Switch over to i2c_freq_mode_string() On Wednesday, March 31, 2021, Song Bao Hua (Barry

RE: [PATCH 5/5] i2c: designware: Switch over to i2c_freq_mode_string()

2021-03-30 Thread Song Bao Hua (Barry Song)
> -Original Message- > From: yangyicong > Sent: Wednesday, March 31, 2021 3:19 AM > To: w...@kernel.org; andriy.shevche...@linux.intel.com; > linux-...@vger.kernel.org; sergey.se...@baikalelectronics.ru; > linux-kernel@vger.kernel.org > Cc: dig...@gmail.com; tred...@nvidia.com;