From: Tilman Schmidt
Date: Thu, 13 Sep 2012 11:52:27 +0200
> Am 12.09.2012 17:06, schrieb Peter Senna Tschudin:
>> From: Peter Senna Tschudin
>>
>> Remove useless kfree() and clean up code related to the removal.
>>
>> The semantic patch that finds this problem is as follows:
> [...]
>>
>>
Am 12.09.2012 17:06, schrieb Peter Senna Tschudin:
> From: Peter Senna Tschudin
>
> Remove useless kfree() and clean up code related to the removal.
>
> The semantic patch that finds this problem is as follows:
[...]
>
> Signed-off-by: Peter Senna Tschudin
Acked-by: Tilman Schmidt
> ---
>
> Seems to me that (assuming kfree(NULL) is ok) the kfree()
> is best left in - just in case some other error path is
> added after drv->cs is assigned.
> Better safe than a memory leak.
I'm not sure if I got your point. Now the label "error:" is only
reached if drv->cs is NULL. There is not
On Thu, Sep 13, 2012 at 09:31:45AM +0100, David Laight wrote:
> > Remove useless kfree() and clean up code related to the removal.
> ...
> > diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c
> > index aa41485..30a6b17 100644
> > --- a/drivers/isdn/gigaset/common.c
> > +++
> Remove useless kfree() and clean up code related to the removal.
...
> diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c
> index aa41485..30a6b17 100644
> --- a/drivers/isdn/gigaset/common.c
> +++ b/drivers/isdn/gigaset/common.c
> @@ -1123,7 +1123,6 @@ struct
Remove useless kfree() and clean up code related to the removal.
...
diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c
index aa41485..30a6b17 100644
--- a/drivers/isdn/gigaset/common.c
+++ b/drivers/isdn/gigaset/common.c
@@ -1123,7 +1123,6 @@ struct gigaset_driver
On Thu, Sep 13, 2012 at 09:31:45AM +0100, David Laight wrote:
Remove useless kfree() and clean up code related to the removal.
...
diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c
index aa41485..30a6b17 100644
--- a/drivers/isdn/gigaset/common.c
+++
Seems to me that (assuming kfree(NULL) is ok) the kfree()
is best left in - just in case some other error path is
added after drv-cs is assigned.
Better safe than a memory leak.
I'm not sure if I got your point. Now the label error: is only
reached if drv-cs is NULL. There is not other way to
Am 12.09.2012 17:06, schrieb Peter Senna Tschudin:
From: Peter Senna Tschudin peter.se...@gmail.com
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
[...]
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
From: Tilman Schmidt til...@imap.cc
Date: Thu, 13 Sep 2012 11:52:27 +0200
Am 12.09.2012 17:06, schrieb Peter Senna Tschudin:
From: Peter Senna Tschudin peter.se...@gmail.com
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as
10 matches
Mail list logo