On Wed, Jan 09, 2013 at 02:34:40AM +, Kim, Milo wrote:
> - goto wash;
> +
> + if (ret == -EBUSY && config->is_gpio_shared)
> + shared_ena_pin = true;
> +
> + if (!shared_ena_pin)
> +
On Wed, Jan 09, 2013 at 02:34:40AM +, Kim, Milo wrote:
- goto wash;
+
+ if (ret == -EBUSY config-is_gpio_shared)
+ shared_ena_pin = true;
+
+ if (!shared_ena_pin)
+ goto
> -Original Message-
> From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com]
> Sent: Tuesday, January 08, 2013 7:44 PM
> To: Axel Lin
> Cc: Kim, Milo; Girdwood, Liam; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH RFT] regulator: lp8788-ldo: Use ldo->en_pin to
> check if
On Tue, Jan 08, 2013 at 12:06:44PM +0800, Axel Lin wrote:
> In this driver,
> There is a case that one gpio controls more than one regulator.
> e.g. ALDO2, ALDO3, ALDO4 are controlled by the same pin.
> It looks like current regulator core does not support this case.
Then the code to cope with
On Mon, Jan 07, 2013 at 11:23:26PM +, Kim, Milo wrote:
> > Applied, thanks. However we should be converting the driver to use the
> > core support for this - the GPIO can just be given to the core in the
> > regulator config which should handle everything transparently.
> I have a question.
On Mon, Jan 07, 2013 at 11:23:26PM +, Kim, Milo wrote:
Applied, thanks. However we should be converting the driver to use the
core support for this - the GPIO can just be given to the core in the
regulator config which should handle everything transparently.
I have a question.
Do
On Tue, Jan 08, 2013 at 12:06:44PM +0800, Axel Lin wrote:
In this driver,
There is a case that one gpio controls more than one regulator.
e.g. ALDO2, ALDO3, ALDO4 are controlled by the same pin.
It looks like current regulator core does not support this case.
Then the code to cope with this
-Original Message-
From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com]
Sent: Tuesday, January 08, 2013 7:44 PM
To: Axel Lin
Cc: Kim, Milo; Girdwood, Liam; linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFT] regulator: lp8788-ldo: Use ldo-en_pin to
check if regulator is
> -Original Message-
> From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com]
> Sent: Monday, January 07, 2013 8:08 PM
> To: Axel Lin
> Cc: Kim, Milo; Girdwood, Liam; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH RFT] regulator: lp8788-ldo: Use ldo->en_pin to
> check if
On Sat, Jan 05, 2013 at 03:33:43PM +0800, Axel Lin wrote:
> ldo->en_pin is set iff the regulator is enabled by external pin.
>
> This patch sets ldo->en_pin to NULL if lp8788_gpio_request_ldo_en() fails,
> then
> we can use it to determinate if the regulator is controlled by external pin or
>
On Sat, Jan 05, 2013 at 03:33:43PM +0800, Axel Lin wrote:
ldo-en_pin is set iff the regulator is enabled by external pin.
This patch sets ldo-en_pin to NULL if lp8788_gpio_request_ldo_en() fails,
then
we can use it to determinate if the regulator is controlled by external pin or
register.
-Original Message-
From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com]
Sent: Monday, January 07, 2013 8:08 PM
To: Axel Lin
Cc: Kim, Milo; Girdwood, Liam; linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFT] regulator: lp8788-ldo: Use ldo-en_pin to
check if regulator is
Hi Axel,
> -Original Message-
> From: Axel Lin [mailto:axel@ingics.com]
> Sent: Saturday, January 05, 2013 4:34 PM
> To: Mark Brown
> Cc: Kim, Milo; Girdwood, Liam; linux-kernel@vger.kernel.org
> Subject: [PATCH RFT] regulator: lp8788-ldo: Use ldo->en_pin to check if
> regulator is
Hi Axel,
-Original Message-
From: Axel Lin [mailto:axel@ingics.com]
Sent: Saturday, January 05, 2013 4:34 PM
To: Mark Brown
Cc: Kim, Milo; Girdwood, Liam; linux-kernel@vger.kernel.org
Subject: [PATCH RFT] regulator: lp8788-ldo: Use ldo-en_pin to check if
regulator is enabled by
14 matches
Mail list logo
