Re: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support

2019-09-22 Thread Pavel Machek
Hi! > >>Why is it global struct? It seems to be flexible configurable over > >>devicetree. > >>So I would assume it should be able to handle more then one button. Please > >>remove global variables, make it allocatable per OF node. > > > >There is ONLY one button available for SC key, but yes, I

Re: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support

2019-09-03 Thread Oleksij Rempel
On 03.09.19 09:35, Anson Huang wrote: Hi, Oleksij On 03.09.19 08:48, Anson Huang wrote: Hi, Oleksij On 03.09.19 16:03, Anson Huang wrote: i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller inside, the system controller is in charge of controlling power, clock and power key

RE: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support

2019-09-03 Thread Anson Huang
Hi, Oleksij > On 03.09.19 08:48, Anson Huang wrote: > > Hi, Oleksij > > > >> On 03.09.19 16:03, Anson Huang wrote: > >>> i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller > >>> inside, the system controller is in charge of controlling power, > >>> clock and power key etc.. > >>> >

Re: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support

2019-09-03 Thread Oleksij Rempel
On 03.09.19 08:48, Anson Huang wrote: Hi, Oleksij On 03.09.19 16:03, Anson Huang wrote: i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller inside, the system controller is in charge of controlling power, clock and power key etc.. Adds i.MX system controller power key driver

RE: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support

2019-09-03 Thread Anson Huang
Hi, Oleksij > On 03.09.19 16:03, Anson Huang wrote: > > i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller > > inside, the system controller is in charge of controlling power, clock > > and power key etc.. > > > > Adds i.MX system controller power key driver support, Linux kernel

Re: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support

2019-09-03 Thread Oleksij Rempel
Hi, On 03.09.19 16:03, Anson Huang wrote: i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller inside, the system controller is in charge of controlling power, clock and power key etc.. Adds i.MX system controller power key driver support, Linux kernel has to communicate with

Re: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support

2019-09-03 Thread Dmitry Torokhov
On Mon, Sep 2, 2019 at 8:11 PM Anson Huang wrote: > > Hi, Fabio > > > On Mon, Sep 2, 2019 at 11:05 PM Anson Huang > > wrote: > > > > > + ret = input_register_device(input); > > > + if (ret < 0) { > > > + dev_err(>dev, "failed to register input device\n"); > > > +

RE: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support

2019-09-02 Thread Anson Huang
Hi, Fabio > On Mon, Sep 2, 2019 at 11:05 PM Anson Huang > wrote: > > > + ret = input_register_device(input); > > + if (ret < 0) { > > + dev_err(>dev, "failed to register input device\n"); > > + return ret; > > + } > > + > > + pdata->input =

Re: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support

2019-09-02 Thread Fabio Estevam
Hi Anson, On Mon, Sep 2, 2019 at 11:05 PM Anson Huang wrote: > + ret = input_register_device(input); > + if (ret < 0) { > + dev_err(>dev, "failed to register input device\n"); > + return ret; > + } > + > + pdata->input = input; > +