RE: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-07-22 Thread Salil Mehta
.kernel.org; Linuxarm > Subject: Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the > HNAE3 framework > > On Wed, Jun 14, 2017 at 12:10:29AM +0100, Salil Mehta wrote: > > This patch adds the support of the HNAE3 (Hisilicon Network > > Acceleration Engine 3) framework

RE: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-07-22 Thread Salil Mehta
.kernel.org; Linuxarm > Subject: Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the > HNAE3 framework > > On Wed, Jun 14, 2017 at 12:10:29AM +0100, Salil Mehta wrote: > > This patch adds the support of the HNAE3 (Hisilicon Network > > Acceleration Engine 3) framework

Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-06-18 Thread Andrew Lunn
On Wed, Jun 14, 2017 at 12:10:29AM +0100, Salil Mehta wrote: > This patch adds the support of the HNAE3 (Hisilicon Network > Acceleration Engine 3) framework support to the HNS3 driver. > > Framework facilitates clients like ENET(HNS3 Ethernet Driver), RoCE > and user-space Ethernet drivers (like

Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-06-18 Thread Andrew Lunn
On Wed, Jun 14, 2017 at 12:10:29AM +0100, Salil Mehta wrote: > This patch adds the support of the HNAE3 (Hisilicon Network > Acceleration Engine 3) framework support to the HNS3 driver. > > Framework facilitates clients like ENET(HNS3 Ethernet Driver), RoCE > and user-space Ethernet drivers (like

Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-06-17 Thread Andrew Lunn
> > > +subsys_initcall(hnae3_init); > > > > And the point of this is? > > > > Andrew > This looks weird but not sure how we could have made sure HNAE is available > before other > 2 drivers could have loaded. Changing into module_init() means two other > modules (dependent > upon hnae) if

Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-06-17 Thread Andrew Lunn
> > > +subsys_initcall(hnae3_init); > > > > And the point of this is? > > > > Andrew > This looks weird but not sure how we could have made sure HNAE is available > before other > 2 drivers could have loaded. Changing into module_init() means two other > modules (dependent > upon hnae) if

RE: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-06-17 Thread Salil Mehta
.org; linux- > ker...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the > HNAE3 framework > > On Wed, Jun 14, 2017 at 12:10:29AM +0100, Salil Mehta wrote: > > +static int __init hnae3_init(void) > > +{ > > + return 0; >

RE: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-06-17 Thread Salil Mehta
.org; linux- > ker...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the > HNAE3 framework > > On Wed, Jun 14, 2017 at 12:10:29AM +0100, Salil Mehta wrote: > > +static int __init hnae3_init(void) > > +{ > > + return 0; >

RE: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-06-17 Thread Salil Mehta
.org; linux- > ker...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the > HNAE3 framework > > On Wed, Jun 14, 2017 at 12:10:29AM +0100, Salil Mehta wrote: > > This patch adds the support of the HNAE3 (Hisilicon Network > > Acceleration E

RE: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-06-17 Thread Salil Mehta
.org; linux- > ker...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the > HNAE3 framework > > On Wed, Jun 14, 2017 at 12:10:29AM +0100, Salil Mehta wrote: > > This patch adds the support of the HNAE3 (Hisilicon Network > > Acceleration E

Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-06-13 Thread Andrew Lunn
On Wed, Jun 14, 2017 at 12:10:29AM +0100, Salil Mehta wrote: > +static int __init hnae3_init(void) > +{ > + return 0; > +} > + .. > +subsys_initcall(hnae3_init); And the point of this is? Andrew

Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-06-13 Thread Andrew Lunn
On Wed, Jun 14, 2017 at 12:10:29AM +0100, Salil Mehta wrote: > +static int __init hnae3_init(void) > +{ > + return 0; > +} > + .. > +subsys_initcall(hnae3_init); And the point of this is? Andrew

Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-06-13 Thread Andrew Lunn
On Wed, Jun 14, 2017 at 12:10:29AM +0100, Salil Mehta wrote: > This patch adds the support of the HNAE3 (Hisilicon Network > Acceleration Engine 3) framework support to the HNS3 driver. > > Framework facilitates clients like ENET(HNS3 Ethernet Driver), RoCE > and user-space Ethernet drivers (like

Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-06-13 Thread Andrew Lunn
On Wed, Jun 14, 2017 at 12:10:29AM +0100, Salil Mehta wrote: > This patch adds the support of the HNAE3 (Hisilicon Network > Acceleration Engine 3) framework support to the HNS3 driver. > > Framework facilitates clients like ENET(HNS3 Ethernet Driver), RoCE > and user-space Ethernet drivers (like