RE: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver

2019-05-07 Thread Dragan Cvetic
.kernel.org; > linux-kernel@vger.kernel.org; Derek Kiernan > Subject: Re: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver > > On Tue, May 07, 2019 at 11:55:42AM +, Dragan Cvetic wrote: > > > > > > > -Original Message- > > > From: Greg KH [ma

Re: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver

2019-05-07 Thread Greg KH
linux-arm-ker...@lists.infradead.org; robh...@kernel.org; > > mark.rutl...@arm.com; devicet...@vger.kernel.org; > > linux-kernel@vger.kernel.org; Derek Kiernan > > Subject: Re: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver > > > > On Tue, May 07, 2019 at

RE: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver

2019-05-07 Thread Dragan Cvetic
.kernel.org; > linux-kernel@vger.kernel.org; Derek Kiernan > Subject: Re: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver > > On Tue, May 07, 2019 at 08:48:41AM +, Dragan Cvetic wrote: > > > > > > > -Original Message- > > > From: Greg KH [m

Re: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver

2019-05-07 Thread Greg KH
linux-arm-ker...@lists.infradead.org; robh...@kernel.org; > > mark.rutl...@arm.com; devicet...@vger.kernel.org; > > linux-kernel@vger.kernel.org; Derek Kiernan > > Subject: Re: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver > > > > On Mon, May 06, 2019 at

RE: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver

2019-05-07 Thread Dragan Cvetic
.kernel.org; > linux-kernel@vger.kernel.org; Derek Kiernan > Subject: Re: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver > > On Mon, May 06, 2019 at 12:23:56PM +, Dragan Cvetic wrote: > > > > > > > -Original Message- > > > From: Greg KH [mai

Re: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver

2019-05-06 Thread Greg KH
linux-arm-ker...@lists.infradead.org; robh...@kernel.org; > > mark.rutl...@arm.com; devicet...@vger.kernel.org; > > linux-kernel@vger.kernel.org; Derek Kiernan > > Subject: Re: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver > > > > On Fri, May 03, 2019 at 04:41

RE: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver

2019-05-06 Thread Dragan Cvetic
.kernel.org; > linux-kernel@vger.kernel.org; Derek Kiernan > Subject: Re: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver > > On Fri, May 03, 2019 at 04:41:21PM +, Dragan Cvetic wrote: > > Hi Greg, > > > > Please find my inline comments below, > &g

Re: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver

2019-05-04 Thread Greg KH
18:20 > > To: Dragan Cvetic > > Cc: a...@arndb.de; Michal Simek ; > > linux-arm-ker...@lists.infradead.org; robh...@kernel.org; > > mark.rutl...@arm.com; devicet...@vger.kernel.org; > > linux-kernel@vger.kernel.org; Derek Kiernan > > Subject: Re: [PATCH V3 02/

RE: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver

2019-05-03 Thread Dragan Cvetic
robh...@kernel.org; > mark.rutl...@arm.com; devicet...@vger.kernel.org; > linux-kernel@vger.kernel.org; Derek Kiernan > Subject: Re: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver > > On Sat, Apr 27, 2019 at 11:04:56PM +0100, Dragan Cvetic wrote: > > +#define

Re: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver

2019-05-02 Thread Greg KH
On Sat, Apr 27, 2019 at 11:04:56PM +0100, Dragan Cvetic wrote: > +#define DRIVER_NAME "xilinx_sdfec" > +#define DRIVER_VERSION "0.3" Version means nothing with the driver in the kernel tree, please remove it. > +#define DRIVER_MAX_DEV BIT(MINORBITS) Why this number? Why limit yourself to any nu