RE: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-07-22 Thread Salil Mehta
er...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 > Ethernet Driver for hip08 SoC > > Hi, > On Sat, Jun 17, 2017 at 06:24:24PM +0100, Salil Mehta wrote: > >+struct notifier_block notifier_block; > >+/* Vxlan/Gene

RE: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-07-22 Thread Salil Mehta
er...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 > Ethernet Driver for hip08 SoC > > Hi, > On Sat, Jun 17, 2017 at 06:24:24PM +0100, Salil Mehta wrote: > >+static int hns3_fill_desc(struct hns3_enet_ring *ring, void *priv, >

RE: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-07-22 Thread Salil Mehta
er...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 > Ethernet Driver for hip08 SoC > > Hi, > On Sat, Jun 17, 2017 at 06:24:24PM +0100, Salil Mehta wrote: > >+static int hns3_fill_desc(struct hns3_enet_ring *ring, void *priv, >

RE: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-07-22 Thread Salil Mehta
.org; linux- > ker...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 > Ethernet Driver for hip08 SoC > > > +static int hns3_nic_net_up(struct net_device *ndev) > > +{ > > + struct hns3_nic_priv *priv = netdev_priv(ndev); > > + s

RE: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-07-22 Thread Salil Mehta
.org; linux- > ker...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 > Ethernet Driver for hip08 SoC > > > +static int hns3_nic_net_up(struct net_device *ndev) > > +{ > > + struct hns3_nic_priv *priv = netdev_priv(ndev); > > + s

Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-18 Thread Bo Yu
Hi, On Sat, Jun 17, 2017 at 06:24:24PM +0100, Salil Mehta wrote: + struct notifier_block notifier_block; + /* Vxlan/Geneve information */ + struct hns3_udp_tunnel udp_tnl[HNS3_UDP_TNL_MAX]; +}; + +/* the distance between [begin, end) in a ring buffer + * note: there is a unuse

Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-18 Thread Bo Yu
Hi, On Sat, Jun 17, 2017 at 06:24:24PM +0100, Salil Mehta wrote: + struct notifier_block notifier_block; + /* Vxlan/Geneve information */ + struct hns3_udp_tunnel udp_tnl[HNS3_UDP_TNL_MAX]; +}; + +/* the distance between [begin, end) in a ring buffer + * note: there is a unuse

Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-18 Thread Bo Yu
Hi, On Sat, Jun 17, 2017 at 06:24:24PM +0100, Salil Mehta wrote: +static int hns3_fill_desc(struct hns3_enet_ring *ring, void *priv, + int size, dma_addr_t dma, int frag_end, + enum hns_desc_type type) +{ + struct hns3_desc_cb *desc_cb =

Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-18 Thread Bo Yu
Hi, On Sat, Jun 17, 2017 at 06:24:24PM +0100, Salil Mehta wrote: +static int hns3_fill_desc(struct hns3_enet_ring *ring, void *priv, + int size, dma_addr_t dma, int frag_end, + enum hns_desc_type type) +{ + struct hns3_desc_cb *desc_cb =

Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-17 Thread Andrew Lunn
> + > + for (i = 0; i < priv->vector_num; i++) { > + tqp_vectors = >tqp_vector[i]; > + > + if (tqp_vectors->irq_init_flag == HNS3_VEVTOR_INITED) Should VEVTOR be VECTOR? > +static void hns3_set_vector_gl(struct hns3_enet_tqp_vector *tqp_vector, > +

Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-17 Thread Andrew Lunn
> + > + for (i = 0; i < priv->vector_num; i++) { > + tqp_vectors = >tqp_vector[i]; > + > + if (tqp_vectors->irq_init_flag == HNS3_VEVTOR_INITED) Should VEVTOR be VECTOR? > +static void hns3_set_vector_gl(struct hns3_enet_tqp_vector *tqp_vector, > +

Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-17 Thread Andrew Lunn
> +static int hns3_nic_net_up(struct net_device *ndev) > +{ > + struct hns3_nic_priv *priv = netdev_priv(ndev); > + struct hnae3_handle *h = priv->ae_handle; > + int i, j; > + int ret; > + > + ret = hns3_nic_init_irq(priv); > + if (ret != 0) { if (ret) No need to

Re: [PATCH V3 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC

2017-06-17 Thread Andrew Lunn
> +static int hns3_nic_net_up(struct net_device *ndev) > +{ > + struct hns3_nic_priv *priv = netdev_priv(ndev); > + struct hnae3_handle *h = priv->ae_handle; > + int i, j; > + int ret; > + > + ret = hns3_nic_init_irq(priv); > + if (ret != 0) { if (ret) No need to