Re: [PATCH net] hvsock: fix epollout hang from race condition

2019-06-17 Thread David Miller
From: Sunil Muthuswamy Date: Mon, 17 Jun 2019 19:27:45 + > The patch does not change at all. So, I was hoping we could reapply > it. But, I have resubmitted the patch. Thanks. It's easy for me to track things if you just resubmit the patch. That's why I ask for things to be done this way,

RE: [PATCH net] hvsock: fix epollout hang from race condition

2019-06-17 Thread Sunil Muthuswamy
p...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH net] hvsock: fix epollout hang from race condition > > From: Sunil Muthuswamy > Date: Mon, 17 Jun 2019 18:47:08 + > > > > > > >> -Original Message- > >> From: linux-hyperv-

Re: [PATCH net] hvsock: fix epollout hang from race condition

2019-06-17 Thread David Miller
uswamy ; KY Srinivasan >> ; Haiyang Zhang ; >> Stephen Hemminger ; sas...@kernel.org; Michael >> Kelley ; >> net...@vger.kernel.org; linux-hyp...@vger.kernel.org; >> linux-kernel@vger.kernel.org >> Subject: Re: [PATCH net] hvsock: fix epollout hang from ra

RE: [PATCH net] hvsock: fix epollout hang from race condition

2019-06-17 Thread Sunil Muthuswamy
ichael Kelley > ; > net...@vger.kernel.org; linux-hyp...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH net] hvsock: fix epollout hang from race condition > > From: Dexuan Cui > Date: Sat, 15 Jun 2019 03:22:32 + > > > These warnings are not introdu

Re: [PATCH net] hvsock: fix epollout hang from race condition

2019-06-16 Thread David Miller
From: Dexuan Cui Date: Sat, 15 Jun 2019 03:22:32 + > These warnings are not introduced by this patch from Sunil. > > I'm not sure why I didn't notice these warnings before. > Probably my gcc version is not new eought? > > Actually these warnings are bogus, as I checked the related

RE: [PATCH net] hvsock: fix epollout hang from race condition

2019-06-15 Thread Dexuan Cui
> From: Sunil Muthuswamy > Sent: Saturday, June 15, 2019 12:23 AM > To: Dexuan Cui ; David Miller > > ... > > It looks a simple inline assembly code can confuse gcc. I'm not sure if I > > should > > report a bug for gcc... > > > > I posted a patch to suppress these bogus warnings just now. The

RE: [PATCH net] hvsock: fix epollout hang from race condition

2019-06-15 Thread Sunil Muthuswamy
hyp...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: RE: [PATCH net] hvsock: fix epollout hang from race condition > > > From: linux-hyperv-ow...@vger.kernel.org > > On Behalf Of Dexuan Cui > > Sent: Friday, June 14, 2019 8:23 PM > > To: David Miller ;

RE: [PATCH net] hvsock: fix epollout hang from race condition

2019-06-14 Thread Dexuan Cui
ger.kernel.org; > linux-hyp...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: RE: [PATCH net] hvsock: fix epollout hang from race condition > > > From: linux-hyperv-ow...@vger.kernel.org > > On Behalf Of David Miller > > Sent: Friday, June 14, 2019 7:15 PM > >

RE: [PATCH net] hvsock: fix epollout hang from race condition

2019-06-14 Thread Dexuan Cui
> From: linux-hyperv-ow...@vger.kernel.org > On Behalf Of David Miller > Sent: Friday, June 14, 2019 7:15 PM > To: Sunil Muthuswamy > > This adds lots of new warnings: > > net/vmw_vsock/hyperv_transport.c: In function ‘hvs_probe’: > net/vmw_vsock/hyperv_transport.c:205:20: warning: ‘vnew’ may

Re: [PATCH net] hvsock: fix epollout hang from race condition

2019-06-14 Thread David Miller
This adds lots of new warnings: net/vmw_vsock/hyperv_transport.c: In function ‘hvs_probe’: net/vmw_vsock/hyperv_transport.c:205:20: warning: ‘vnew’ may be used uninitialized in this function [-Wmaybe-uninitialized] remote->svm_port = host_ephemeral_port++;

RE: [PATCH net] hvsock: fix epollout hang from race condition

2019-06-13 Thread Dexuan Cui
> From: Sunil Muthuswamy > Sent: Wednesday, June 12, 2019 2:19 PM > ... > The fix is to set the pending size to the default size and never change it. > This way the host will always notify the guest whenever the writable space > is bigger than the pending size. The host is already optimized to