RE: [PATCH net-next 6/7] r8169: add a new chip for RTL8106E

2013-04-01 Thread hayeswang
Francois Romieu [mailto:rom...@fr.zoreil.com] > Sent: Tuesday, April 02, 2013 6:24 AM > To: Hayeswang > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH net-next 6/7] r8169: add a new chip for RTL8106E > > Hayes Wang :

Re: [PATCH net-next 6/7] r8169: add a new chip for RTL8106E

2013-04-01 Thread Francois Romieu
Hayes Wang : [...] > - move rtl_set_rx_tx_desc_registers to avoid the tx/rx are enabled > before setting desc registers. This is a wholesale change for the 810x family. Please explain why issuing rtl_set_rx_tx_desc_registers before writing ChipCmd is not enough and feed it through a standalone