RE: [PATCH net-next v2 3/3] net: stmmac: Introducing support for Page Pool

From: Jesper Dangaard Brouer > This code is okay, but I would likely write it as: > > if (rx_q->page_pool) { > page_pool_request_shutdown(rx_q->page_pool)); > page_pool_free(rx_q->page_pool); > } > > Because (as you noticed) page_pool_free() have some API misuse checks, > that

Re: [PATCH net-next v2 3/3] net: stmmac: Introducing support for Page Pool

On Thu, 4 Jul 2019 17:04:14 +0200 Jose Abreu wrote: > @@ -1498,8 +1480,9 @@ static void free_dma_rx_desc_resources(struct > stmmac_priv *priv) > sizeof(struct dma_extended_desc), > rx_q->dma_erx, rx_q->dma_rx_phy);