; Vadim Pasternak
> ; David Woods ; Liming Sun
> ; platform-driver-
> x...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v1 1/1] platform/mellanox: Add bootctl driver for
> Mellanox BlueField Soc
>
> Hi Liming,
>
> Thank you for the patch! Yet some
Hi Liming,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.0-rc4 next-20190131]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
Pasternak ; David
> Woods ; Platform Driver
> ; Linux Kernel Mailing List ker...@vger.kernel.org>
> Subject: Re: [PATCH v1 1/1] platform/mellanox: Add bootctl driver for
> Mellanox BlueField Soc
>
> On Wed, Jan 30, 2019 at 10:47 PM Liming Sun wrote:
>
> > > F
On Wed, Jan 30, 2019 at 10:47 PM Liming Sun wrote:
> > First of all, is it a real watchdog with a driver? I think watchdog in
> > that case should be set up through standard watchdog facilities.
>
> This is not a watchdog driver itself. Instead, it provides interface to
> user-space and use ARM
form
> Driver ; Linux Kernel Mailing List
>
> Subject: RE: [PATCH v1 1/1] platform/mellanox: Add bootctl driver for
> Mellanox BlueField Soc
>
>
> [...]
>
> Please, be consistent with naming convention.
> All the above should have same prefix as others routines.
I fix
Tuesday, January 29, 2019 5:03 PM
> To: Liming Sun
> Cc: Andy Shevchenko ; Darren Hart ;
> Vadim Pasternak ; David
> Woods ; Platform Driver
> ; Linux Kernel Mailing List ker...@vger.kernel.org>
> Subject: Re: [PATCH v1 1/1] platform/mellanox: Add bootctl driver for
>
[...]
Please, be consistent with naming convention.
All the above should have same prefix as others routines.
>
> > +static ssize_t post_reset_wdog_store(struct device_driver *drv,
> > +const char *buf, size_t count) {
> > + int err;
> > +
On Tue, Jan 29, 2019 at 10:59 PM Liming Sun wrote:
>
> This commit adds the bootctl platform driver for Mellanox BlueField
> Soc, which controls the eMMC boot partition swapping and related
> watchdog configuration.
Thanks for the patch.
My comments below.
First of all, is it a real watchdog
8 matches
Mail list logo
