Re: [PATCH v1 1/1] scsi: ufshcd: Allow zero value setting to Auto-Hibernate Timer

2020-09-15 Thread Martin K. Petersen
On Fri, 28 Aug 2020 18:05:13 -0700, Bao D. Nguyen wrote: > The zero value Auto-Hibernate Timer is a valid setting, and it > indicates the Auto-Hibernate feature being disabled. Correctly > support this setting. In addition, when this value is queried > from sysfs, read from the host controller's r

Re: [PATCH v1 1/1] scsi: ufshcd: Allow zero value setting to Auto-Hibernate Timer

2020-09-08 Thread Martin K. Petersen
Bao, > The zero value Auto-Hibernate Timer is a valid setting, and it > indicates the Auto-Hibernate feature being disabled. Correctly support > this setting. In addition, when this value is queried from sysfs, read > from the host controller's register and return that value instead of > using t

RE: [PATCH v1 1/1] scsi: ufshcd: Allow zero value setting to Auto-Hibernate Timer

2020-09-03 Thread Stanley Chu
On Wed, 2020-09-02 at 05:10 +, Avri Altman wrote: > > > > On 2020-08-29 00:32, Avri Altman wrote: > > >> > > >> The zero value Auto-Hibernate Timer is a valid setting, and it > > >> indicates the Auto-Hibernate feature being disabled. Correctly > > > Right. So " ufshcd_auto_hibern8_enable" is

RE: [PATCH v1 1/1] scsi: ufshcd: Allow zero value setting to Auto-Hibernate Timer

2020-09-01 Thread Avri Altman
> > On 2020-08-29 00:32, Avri Altman wrote: > >> > >> The zero value Auto-Hibernate Timer is a valid setting, and it > >> indicates the Auto-Hibernate feature being disabled. Correctly > > Right. So " ufshcd_auto_hibern8_enable" is no longer an appropriate > > name. > > Maybe ufshcd_auto_hibern8

Re: [PATCH v1 1/1] scsi: ufshcd: Allow zero value setting to Auto-Hibernate Timer

2020-08-31 Thread nguyenb
On 2020-08-29 00:32, Avri Altman wrote: The zero value Auto-Hibernate Timer is a valid setting, and it indicates the Auto-Hibernate feature being disabled. Correctly Right. So " ufshcd_auto_hibern8_enable" is no longer an appropriate name. Maybe ufshcd_auto_hibern8_set instead? Thanks for you

Re: [PATCH v1 1/1] scsi: ufshcd: Allow zero value setting to Auto-Hibernate Timer

2020-08-31 Thread nguyenb
On 2020-08-28 20:13, Bart Van Assche wrote: On 2020-08-28 18:05, Bao D. Nguyen wrote: static ssize_t auto_hibern8_show(struct device *dev, struct device_attribute *attr, char *buf) { + u32 ahit; struct ufs_hba *hba = dev_get_drvdata(dev); Althou

RE: [PATCH v1 1/1] scsi: ufshcd: Allow zero value setting to Auto-Hibernate Timer

2020-08-29 Thread Avri Altman
> > The zero value Auto-Hibernate Timer is a valid setting, and it > indicates the Auto-Hibernate feature being disabled. Correctly Right. So " ufshcd_auto_hibern8_enable" is no longer an appropriate name. Maybe ufshcd_auto_hibern8_set instead? Also, did you verified that no other platform reli

Re: [PATCH v1 1/1] scsi: ufshcd: Allow zero value setting to Auto-Hibernate Timer

2020-08-28 Thread Bart Van Assche
On 2020-08-28 18:05, Bao D. Nguyen wrote: > static ssize_t auto_hibern8_show(struct device *dev, >struct device_attribute *attr, char *buf) > { > + u32 ahit; > struct ufs_hba *hba = dev_get_drvdata(dev); Although not strictly required for SCSI code, how