RE: [PATCH v1 1/2] regulator: pca9450: add enable_val for all bucks

2020-09-29 Thread Robin Gong
On 2020/09/01 9:58 Robin Gong wrote: > On 2020/08/31 18:53 Marco Felsch wrote: > > Hi Robin, > > > > On 20-09-01 00:48, Robin Gong wrote: > > > BuckX enable mode > > > 00b = OFF > > > 01b = ON by PMIC_ON_REQ = H > > > 10b = ON by PMIC_ON_REQ = H && PMIC_STBY_REQ = L 11b = Always ON > > > > > > Fo

RE: [PATCH v1 1/2] regulator: pca9450: add enable_val for all bucks

2020-08-31 Thread Robin Gong
On 2020/08/31 18:53 Marco Felsch wrote: > Hi Robin, > > On 20-09-01 00:48, Robin Gong wrote: > > BuckX enable mode > > 00b = OFF > > 01b = ON by PMIC_ON_REQ = H > > 10b = ON by PMIC_ON_REQ = H && PMIC_STBY_REQ = L 11b = Always ON > > > > For such enable mode, enable_value should be clearly set in

Re: [PATCH v1 1/2] regulator: pca9450: add enable_val for all bucks

2020-08-31 Thread Marco Felsch
Hi Robin, On 20-09-01 00:48, Robin Gong wrote: > BuckX enable mode > 00b = OFF > 01b = ON by PMIC_ON_REQ = H > 10b = ON by PMIC_ON_REQ = H && PMIC_STBY_REQ = L > 11b = Always ON > > For such enable mode, enable_value should be clearly set in requlator desc, > 00/11 is not enough, correct it now f