RE: [PATCH v2] SFI: fix compilation warnings

2013-12-10 Thread Zheng, Lv
Hi, > From: linux-acpi-ow...@vger.kernel.org > [mailto:linux-acpi-ow...@vger.kernel.org] On Behalf Of Andy Shevchenko > Sent: Tuesday, December 10, 2013 8:08 PM > > On Tue, 2013-12-10 at 01:30 +, Zheng, Lv wrote: > > Hi, Andy > > > > IMO: > > 1. sfi_acpi.h should include both and and it >

Re: [PATCH v2] SFI: fix compilation warnings

2013-12-10 Thread Andy Shevchenko
On Tue, 2013-12-10 at 01:30 +, Zheng, Lv wrote: > Hi, Andy > > IMO: > 1. sfi_acpi.h should include both and and it > should include for !CONFIG_ACPI builds. > 2. then we should include sfi_acpi.h instead of , > and for all of its users. > > I think the patch in the linux-pm/bleeding-ed

Re: [PATCH v2] SFI: fix compilation warnings

2013-12-10 Thread Andy Shevchenko
On Tue, 2013-12-10 at 01:30 +, Zheng, Lv wrote: > Hi, Andy > > IMO: > 1. sfi_acpi.h should include both and and it > should include for !CONFIG_ACPI builds. > 2. then we should include sfi_acpi.h instead of , > and for all of its users. > > I think the patch in the linux-pm/bleeding-ed

RE: [PATCH v2] SFI: fix compilation warnings

2013-12-09 Thread Zheng, Lv
Hi, Andy IMO: 1. sfi_acpi.h should include both and and it should include for !CONFIG_ACPI builds. 2. then we should include sfi_acpi.h instead of , and for all of its users. I think the patch in the linux-pm/bleeding-edge queue can fix the issue you've reported: https://git.kernel.org/cg