RE: [PATCH v2] x86/hyperv: make vapic support x2apic mode

2019-10-08 Thread Michael Kelley
From: Michael Kelley Sent: Friday, October 4, 2019 3:33 PM > > From: Roman Kagan Sent: Friday, October 4, 2019 2:19 AM > > > > On Fri, Oct 04, 2019 at 03:01:51AM +, Michael Kelley wrote: > > > From: Roman Kagan Sent: Thursday, October 3, 2019 > > > 5:53 AM > > > > > > > > > > AFAIU

RE: [PATCH v2] x86/hyperv: make vapic support x2apic mode

2019-10-04 Thread Michael Kelley
From: Roman Kagan Sent: Friday, October 4, 2019 2:19 AM > > On Fri, Oct 04, 2019 at 03:01:51AM +, Michael Kelley wrote: > > From: Roman Kagan Sent: Thursday, October 3, 2019 > > 5:53 AM > > > > > > > > AFAIU you're trying to mirror native_x2apic_icr_write() here but this is > > > >

Re: [PATCH v2] x86/hyperv: make vapic support x2apic mode

2019-10-04 Thread Roman Kagan
On Fri, Oct 04, 2019 at 03:01:51AM +, Michael Kelley wrote: > From: Roman Kagan Sent: Thursday, October 3, 2019 5:53 > AM > > > > > > AFAIU you're trying to mirror native_x2apic_icr_write() here but this is > > > different from what hv_apic_icr_write() does > > > (SET_APIC_DEST_FIELD(id)). >

RE: [PATCH v2] x86/hyperv: make vapic support x2apic mode

2019-10-03 Thread Michael Kelley
From: Roman Kagan Sent: Thursday, October 3, 2019 5:53 AM > > > > AFAIU you're trying to mirror native_x2apic_icr_write() here but this is > > different from what hv_apic_icr_write() does > > (SET_APIC_DEST_FIELD(id)). > > Right. In xapic mode the ICR2 aka the high 4 bytes of ICR is programmed

Re: [PATCH v2] x86/hyperv: make vapic support x2apic mode

2019-10-03 Thread Roman Kagan
On Thu, Oct 03, 2019 at 12:54:03PM +0200, Vitaly Kuznetsov wrote: > Roman Kagan writes: > > > Now that there's Hyper-V IOMMU driver, Linux can switch to x2apic mode > > when supported by the vcpus. > > > > However, the apic access functions for Hyper-V enlightened apic assume > > xapic mode

Re: [PATCH v2] x86/hyperv: make vapic support x2apic mode

2019-10-03 Thread Vitaly Kuznetsov
Roman Kagan writes: > Now that there's Hyper-V IOMMU driver, Linux can switch to x2apic mode > when supported by the vcpus. > > However, the apic access functions for Hyper-V enlightened apic assume > xapic mode only. > > As a result, Linux fails to bring up secondary cpus when run as a guest >