RE: [PATCH v2] z3fold: fix reclaim lock-ups

A headless page also need to be set UNDER_RECLAIM in previous reply, but I missed it. --- mm/z3fold.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/z3fold.c b/mm/z3fold.c index 5f659ab..8536a47 100644 --- a/mm/z3fold.c +++ b/mm/z3fold.c @@ -849,10 +849,10 @@ static int

RE: [PATCH v2] z3fold: fix reclaim lock-ups

A headless page also need to be set UNDER_RECLAIM in previous reply, but I missed it. --- mm/z3fold.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/z3fold.c b/mm/z3fold.c index 5f659ab..8536a47 100644 --- a/mm/z3fold.c +++ b/mm/z3fold.c @@ -849,10 +849,10 @@ static int

Re: [PATCH v2] z3fold: fix reclaim lock-ups

> Hi Jongseok, > I don't see how that is relevant, we don't use zhdr variable if the page is headless anyway. > Thanks, that is indeed a valid fix, but given the operation of eviction in > zswap case, I'd prefer to release the page here and not in _free(). > Basically we should bail very early

Re: [PATCH v2] z3fold: fix reclaim lock-ups

> Hi Jongseok, > I don't see how that is relevant, we don't use zhdr variable if the page is headless anyway. > Thanks, that is indeed a valid fix, but given the operation of eviction in > zswap case, I'd prefer to release the page here and not in _free(). > Basically we should bail very early

Re: [PATCH v2] z3fold: fix reclaim lock-ups

Hi Jongseok, Den tors 3 maj 2018 kl 08:36 skrev Jongseok Kim : > In the processing of headless pages, there was a problem that the > zhdr pointed to another page or a page was alread released in > z3fold_free(). So, the wrong page is encoded in headless, or test_bit > does not

Re: [PATCH v2] z3fold: fix reclaim lock-ups

Hi Jongseok, Den tors 3 maj 2018 kl 08:36 skrev Jongseok Kim : > In the processing of headless pages, there was a problem that the > zhdr pointed to another page or a page was alread released in > z3fold_free(). So, the wrong page is encoded in headless, or test_bit > does not work properly in