Re: [PATCH v2 04/10] pwm: pwm-tiecap: Add device-tree binding support for APWM driver

2012-11-09 Thread Thierry Reding
On Fri, Nov 09, 2012 at 10:59:30AM +, Philip, Avinash wrote: > On Fri, Nov 09, 2012 at 13:22:19, Thierry Reding wrote: > > On Thu, Nov 08, 2012 at 01:23:11PM +0530, Philip, Avinash wrote: > > > +#define ECAPCLK_EN BIT(0) > > > +#define ECAPCLK_STOP_REQ BIT(1) > > > >

RE: [PATCH v2 04/10] pwm: pwm-tiecap: Add device-tree binding support for APWM driver

2012-11-09 Thread Philip, Avinash
On Fri, Nov 09, 2012 at 13:22:19, Thierry Reding wrote: > On Thu, Nov 08, 2012 at 01:23:11PM +0530, Philip, Avinash wrote: > > This patch > > 1. Add support for device-tree binding for ECAP APWM driver. > > 2. Set size of pwm-cells set to 3 to support PWM channel number, PWM > >period &

Re: [PATCH v2 04/10] pwm: pwm-tiecap: Add device-tree binding support for APWM driver

2012-11-09 Thread Thierry Reding
On Fri, Nov 09, 2012 at 08:52:19AM +0100, Thierry Reding wrote: > On Thu, Nov 08, 2012 at 01:23:11PM +0530, Philip, Avinash wrote: [...] > > static int __devinit ecap_pwm_probe(struct platform_device *pdev) > > __devinit can go away. [...] > > static int __devexit ecap_pwm_remove(struct

Re: [PATCH v2 04/10] pwm: pwm-tiecap: Add device-tree binding support for APWM driver

2012-11-09 Thread Thierry Reding
On Fri, Nov 09, 2012 at 08:52:19AM +0100, Thierry Reding wrote: On Thu, Nov 08, 2012 at 01:23:11PM +0530, Philip, Avinash wrote: [...] static int __devinit ecap_pwm_probe(struct platform_device *pdev) __devinit can go away. [...] static int __devexit ecap_pwm_remove(struct

RE: [PATCH v2 04/10] pwm: pwm-tiecap: Add device-tree binding support for APWM driver

2012-11-09 Thread Philip, Avinash
On Fri, Nov 09, 2012 at 13:22:19, Thierry Reding wrote: On Thu, Nov 08, 2012 at 01:23:11PM +0530, Philip, Avinash wrote: This patch 1. Add support for device-tree binding for ECAP APWM driver. 2. Set size of pwm-cells set to 3 to support PWM channel number, PWM period polarity

Re: [PATCH v2 04/10] pwm: pwm-tiecap: Add device-tree binding support for APWM driver

2012-11-09 Thread Thierry Reding
On Fri, Nov 09, 2012 at 10:59:30AM +, Philip, Avinash wrote: On Fri, Nov 09, 2012 at 13:22:19, Thierry Reding wrote: On Thu, Nov 08, 2012 at 01:23:11PM +0530, Philip, Avinash wrote: +#define ECAPCLK_EN BIT(0) +#define ECAPCLK_STOP_REQ BIT(1) This one doesn't

Re: [PATCH v2 04/10] pwm: pwm-tiecap: Add device-tree binding support for APWM driver

2012-11-08 Thread Thierry Reding
On Thu, Nov 08, 2012 at 01:23:11PM +0530, Philip, Avinash wrote: > This patch > 1. Add support for device-tree binding for ECAP APWM driver. > 2. Set size of pwm-cells set to 3 to support PWM channel number, PWM >period & polarity configuration from device tree. > 3. Add enable/disable clock

Re: [PATCH v2 04/10] pwm: pwm-tiecap: Add device-tree binding support for APWM driver

2012-11-08 Thread Thierry Reding
On Thu, Nov 08, 2012 at 01:23:11PM +0530, Philip, Avinash wrote: This patch 1. Add support for device-tree binding for ECAP APWM driver. 2. Set size of pwm-cells set to 3 to support PWM channel number, PWM period polarity configuration from device tree. 3. Add enable/disable clock gating