Re: [PATCH v2 1/2] mmc: dw_mmc: exynos: Stop claiming wp-gpio

2012-11-29 Thread Doug Anderson
Seungwon, On Wed, Nov 28, 2012 at 11:46 PM, Seungwon Jeon wrote: > Hi Doug, > > On Thursday, November 29, 2012, Doug Anderson wrote: >> Seungwon, >> >> Thanks for the review. See below for comments. If you'd like me to >> respin then please let me know. Otherwise I look forward to your ack.

Re: [PATCH v2 1/2] mmc: dw_mmc: exynos: Stop claiming wp-gpio

2012-11-29 Thread Doug Anderson
Seungwon, On Wed, Nov 28, 2012 at 11:46 PM, Seungwon Jeon tgih@samsung.com wrote: Hi Doug, On Thursday, November 29, 2012, Doug Anderson wrote: Seungwon, Thanks for the review. See below for comments. If you'd like me to respin then please let me know. Otherwise I look forward to

RE: [PATCH v2 1/2] mmc: dw_mmc: exynos: Stop claiming wp-gpio

2012-11-28 Thread Seungwon Jeon
Hi Doug, On Thursday, November 29, 2012, Doug Anderson wrote: > Seungwon, > > Thanks for the review. See below for comments. If you'd like me to > respin then please let me know. Otherwise I look forward to your ack. > > On Wed, Nov 28, 2012 at 1:29 AM, Seungwon Jeon wrote: > > Yes. pin of

Re: [PATCH v2 1/2] mmc: dw_mmc: exynos: Stop claiming wp-gpio

2012-11-28 Thread Doug Anderson
Seungwon, Thanks for the review. See below for comments. If you'd like me to respin then please let me know. Otherwise I look forward to your ack. On Wed, Nov 28, 2012 at 1:29 AM, Seungwon Jeon wrote: > Yes. pin of write protection is common property. > This change is good. I have some

RE: [PATCH v2 1/2] mmc: dw_mmc: exynos: Stop claiming wp-gpio

2012-11-28 Thread Seungwon Jeon
Yes. pin of write protection is common property. This change is good. I have some suggestion below. Could you check it? On Friday, November 23, 2012, Doug Anderson wrote: > The exynos code claimed wp-gpio with devm_gpio_request() but never did > anything with it. That meant that anyone using a

RE: [PATCH v2 1/2] mmc: dw_mmc: exynos: Stop claiming wp-gpio

2012-11-28 Thread Seungwon Jeon
Yes. pin of write protection is common property. This change is good. I have some suggestion below. Could you check it? On Friday, November 23, 2012, Doug Anderson wrote: The exynos code claimed wp-gpio with devm_gpio_request() but never did anything with it. That meant that anyone using a

Re: [PATCH v2 1/2] mmc: dw_mmc: exynos: Stop claiming wp-gpio

2012-11-28 Thread Doug Anderson
Seungwon, Thanks for the review. See below for comments. If you'd like me to respin then please let me know. Otherwise I look forward to your ack. On Wed, Nov 28, 2012 at 1:29 AM, Seungwon Jeon tgih@samsung.com wrote: Yes. pin of write protection is common property. This change is good.

RE: [PATCH v2 1/2] mmc: dw_mmc: exynos: Stop claiming wp-gpio

2012-11-28 Thread Seungwon Jeon
Hi Doug, On Thursday, November 29, 2012, Doug Anderson wrote: Seungwon, Thanks for the review. See below for comments. If you'd like me to respin then please let me know. Otherwise I look forward to your ack. On Wed, Nov 28, 2012 at 1:29 AM, Seungwon Jeon tgih@samsung.com wrote: