Re: [PATCH v2 1/3] input: cygnus-update touchscreen dt node document

2016-02-26 Thread Raveendra Padasalagi
Thanks Scott and Ray for the inputs. I will implement syscon only register access and send out the changes in patch set - v4. Regards, Raveendra On Tue, Feb 23, 2016 at 1:18 AM, Ray Jui wrote: > > > On 2/22/2016 11:41 AM, Scott Branden wrote: >> >> My comments below >> >>

Re: [PATCH v2 1/3] input: cygnus-update touchscreen dt node document

2016-02-26 Thread Raveendra Padasalagi
Thanks Scott and Ray for the inputs. I will implement syscon only register access and send out the changes in patch set - v4. Regards, Raveendra On Tue, Feb 23, 2016 at 1:18 AM, Ray Jui wrote: > > > On 2/22/2016 11:41 AM, Scott Branden wrote: >> >> My comments below >> >> On 16-02-22 11:36 AM,

Re: [PATCH v2 1/3] input: cygnus-update touchscreen dt node document

2016-02-22 Thread Ray Jui
On 2/22/2016 11:41 AM, Scott Branden wrote: My comments below On 16-02-22 11:36 AM, Dmitry Torokhov wrote: On Fri, Feb 19, 2016 at 11:43:50AM +0530, Raveendra Padasalagi wrote: On Thu, Feb 18, 2016 at 8:06 PM, Rob Herring wrote: On Wed, Feb 17, 2016 at 03:13:44PM +0530,

Re: [PATCH v2 1/3] input: cygnus-update touchscreen dt node document

2016-02-22 Thread Ray Jui
On 2/22/2016 11:41 AM, Scott Branden wrote: My comments below On 16-02-22 11:36 AM, Dmitry Torokhov wrote: On Fri, Feb 19, 2016 at 11:43:50AM +0530, Raveendra Padasalagi wrote: On Thu, Feb 18, 2016 at 8:06 PM, Rob Herring wrote: On Wed, Feb 17, 2016 at 03:13:44PM +0530, Raveendra

Re: [PATCH v2 1/3] input: cygnus-update touchscreen dt node document

2016-02-22 Thread Scott Branden
My comments below On 16-02-22 11:36 AM, Dmitry Torokhov wrote: On Fri, Feb 19, 2016 at 11:43:50AM +0530, Raveendra Padasalagi wrote: On Thu, Feb 18, 2016 at 8:06 PM, Rob Herring wrote: On Wed, Feb 17, 2016 at 03:13:44PM +0530, Raveendra Padasalagi wrote: In Cygnus SOC touch

Re: [PATCH v2 1/3] input: cygnus-update touchscreen dt node document

2016-02-22 Thread Scott Branden
My comments below On 16-02-22 11:36 AM, Dmitry Torokhov wrote: On Fri, Feb 19, 2016 at 11:43:50AM +0530, Raveendra Padasalagi wrote: On Thu, Feb 18, 2016 at 8:06 PM, Rob Herring wrote: On Wed, Feb 17, 2016 at 03:13:44PM +0530, Raveendra Padasalagi wrote: In Cygnus SOC touch screen

Re: [PATCH v2 1/3] input: cygnus-update touchscreen dt node document

2016-02-22 Thread Dmitry Torokhov
On Fri, Feb 19, 2016 at 11:43:50AM +0530, Raveendra Padasalagi wrote: > On Thu, Feb 18, 2016 at 8:06 PM, Rob Herring wrote: > > On Wed, Feb 17, 2016 at 03:13:44PM +0530, Raveendra Padasalagi wrote: > >> In Cygnus SOC touch screen controller registers are shared > >> with ADC and

Re: [PATCH v2 1/3] input: cygnus-update touchscreen dt node document

2016-02-22 Thread Dmitry Torokhov
On Fri, Feb 19, 2016 at 11:43:50AM +0530, Raveendra Padasalagi wrote: > On Thu, Feb 18, 2016 at 8:06 PM, Rob Herring wrote: > > On Wed, Feb 17, 2016 at 03:13:44PM +0530, Raveendra Padasalagi wrote: > >> In Cygnus SOC touch screen controller registers are shared > >> with ADC and flex timer. Using

Re: [PATCH v2 1/3] input: cygnus-update touchscreen dt node document

2016-02-18 Thread Raveendra Padasalagi
On Thu, Feb 18, 2016 at 8:06 PM, Rob Herring wrote: > On Wed, Feb 17, 2016 at 03:13:44PM +0530, Raveendra Padasalagi wrote: >> In Cygnus SOC touch screen controller registers are shared >> with ADC and flex timer. Using readl/writel could lead to >> race condition. So touch

Re: [PATCH v2 1/3] input: cygnus-update touchscreen dt node document

2016-02-18 Thread Raveendra Padasalagi
On Thu, Feb 18, 2016 at 8:06 PM, Rob Herring wrote: > On Wed, Feb 17, 2016 at 03:13:44PM +0530, Raveendra Padasalagi wrote: >> In Cygnus SOC touch screen controller registers are shared >> with ADC and flex timer. Using readl/writel could lead to >> race condition. So touch screen driver is

Re: [PATCH v2 1/3] input: cygnus-update touchscreen dt node document

2016-02-18 Thread Rob Herring
On Wed, Feb 17, 2016 at 03:13:44PM +0530, Raveendra Padasalagi wrote: > In Cygnus SOC touch screen controller registers are shared > with ADC and flex timer. Using readl/writel could lead to > race condition. So touch screen driver is enhanced to support > > 1. If touchscreen register's are not

Re: [PATCH v2 1/3] input: cygnus-update touchscreen dt node document

2016-02-18 Thread Rob Herring
On Wed, Feb 17, 2016 at 03:13:44PM +0530, Raveendra Padasalagi wrote: > In Cygnus SOC touch screen controller registers are shared > with ADC and flex timer. Using readl/writel could lead to > race condition. So touch screen driver is enhanced to support > > 1. If touchscreen register's are not

RE: [PATCH v2 1/3] input: cygnus-update touchscreen dt node document

2016-02-17 Thread Raveendra Padasalagi
Pawel Moll; > Mark Rutland; Ian Campbell; Kumar Gala; Jonathan Richardson; Jon Mason; > Florian Fainelli; Anup Patel; Ray Jui; Scott Branden; linux- > ker...@vger.kernel.org; bcm-kernel-feedback-l...@broadcom.com > Subject: Re: [PATCH v2 1/3] input: cygnus-update touchscreen dt node

RE: [PATCH v2 1/3] input: cygnus-update touchscreen dt node document

2016-02-17 Thread Raveendra Padasalagi
Pawel Moll; > Mark Rutland; Ian Campbell; Kumar Gala; Jonathan Richardson; Jon Mason; > Florian Fainelli; Anup Patel; Ray Jui; Scott Branden; linux- > ker...@vger.kernel.org; bcm-kernel-feedback-l...@broadcom.com > Subject: Re: [PATCH v2 1/3] input: cygnus-update touchscreen dt node

Re: [PATCH v2 1/3] input: cygnus-update touchscreen dt node document

2016-02-17 Thread Arnd Bergmann
On Wednesday 17 February 2016 15:13:44 Raveendra Padasalagi wrote: > + > + ts_adc_syscon: ts_adc_syscon@0x180a6000 { > + compatible = "syscon"; > + reg = <0x180a6000 0xc30>; > + }; > This should have a more specific compatible string in addition to the

Re: [PATCH v2 1/3] input: cygnus-update touchscreen dt node document

2016-02-17 Thread Arnd Bergmann
On Wednesday 17 February 2016 15:13:44 Raveendra Padasalagi wrote: > + > + ts_adc_syscon: ts_adc_syscon@0x180a6000 { > + compatible = "syscon"; > + reg = <0x180a6000 0xc30>; > + }; > This should have a more specific compatible string in addition to the