RE: [PATCH v2 2/2] acpi/nfit: Issue Start ARS to retrieve existing records

2017-06-16 Thread Kani, Toshimitsu
> On Fri, Jun 16, 2017 at 5:01 PM, Kani, Toshimitsu wrote: > >> > --- a/drivers/acpi/nfit/core.c > >> > +++ b/drivers/acpi/nfit/core.c > >> > @@ -1031,7 +1031,7 @@ static ssize_t scrub_store(struct device *dev, > >> > if (nd_desc) { > >> > struct

RE: [PATCH v2 2/2] acpi/nfit: Issue Start ARS to retrieve existing records

2017-06-16 Thread Kani, Toshimitsu
> On Fri, Jun 16, 2017 at 5:01 PM, Kani, Toshimitsu wrote: > >> > --- a/drivers/acpi/nfit/core.c > >> > +++ b/drivers/acpi/nfit/core.c > >> > @@ -1031,7 +1031,7 @@ static ssize_t scrub_store(struct device *dev, > >> > if (nd_desc) { > >> > struct acpi_nfit_desc *acpi_desc

Re: [PATCH v2 2/2] acpi/nfit: Issue Start ARS to retrieve existing records

2017-06-16 Thread Dan Williams
On Fri, Jun 16, 2017 at 5:01 PM, Kani, Toshimitsu wrote: >> > --- a/drivers/acpi/nfit/core.c >> > +++ b/drivers/acpi/nfit/core.c >> > @@ -1031,7 +1031,7 @@ static ssize_t scrub_store(struct device *dev, >> > if (nd_desc) { >> > struct acpi_nfit_desc

Re: [PATCH v2 2/2] acpi/nfit: Issue Start ARS to retrieve existing records

2017-06-16 Thread Dan Williams
On Fri, Jun 16, 2017 at 5:01 PM, Kani, Toshimitsu wrote: >> > --- a/drivers/acpi/nfit/core.c >> > +++ b/drivers/acpi/nfit/core.c >> > @@ -1031,7 +1031,7 @@ static ssize_t scrub_store(struct device *dev, >> > if (nd_desc) { >> > struct acpi_nfit_desc *acpi_desc =

RE: [PATCH v2 2/2] acpi/nfit: Issue Start ARS to retrieve existing records

2017-06-16 Thread Kani, Toshimitsu
> > --- a/drivers/acpi/nfit/core.c > > +++ b/drivers/acpi/nfit/core.c > > @@ -1031,7 +1031,7 @@ static ssize_t scrub_store(struct device *dev, > > if (nd_desc) { > > struct acpi_nfit_desc *acpi_desc = to_acpi_desc(nd_desc); > > > > - rc =

RE: [PATCH v2 2/2] acpi/nfit: Issue Start ARS to retrieve existing records

2017-06-16 Thread Kani, Toshimitsu
> > --- a/drivers/acpi/nfit/core.c > > +++ b/drivers/acpi/nfit/core.c > > @@ -1031,7 +1031,7 @@ static ssize_t scrub_store(struct device *dev, > > if (nd_desc) { > > struct acpi_nfit_desc *acpi_desc = to_acpi_desc(nd_desc); > > > > - rc =

Re: [PATCH v2 2/2] acpi/nfit: Issue Start ARS to retrieve existing records

2017-06-15 Thread Dan Williams
Thanks for this. I think it's going in the right direction, but one comment below. On Thu, Jun 8, 2017 at 11:36 AM, Toshi Kani wrote: > ACPI 6.2 defines in section 9.20.7.2 that the OSPM may call a Start > ARS with Flags Bit [1] set upon receiving the 0x81 notification. > >

Re: [PATCH v2 2/2] acpi/nfit: Issue Start ARS to retrieve existing records

2017-06-15 Thread Dan Williams
Thanks for this. I think it's going in the right direction, but one comment below. On Thu, Jun 8, 2017 at 11:36 AM, Toshi Kani wrote: > ACPI 6.2 defines in section 9.20.7.2 that the OSPM may call a Start > ARS with Flags Bit [1] set upon receiving the 0x81 notification. > > Upon receiving the