RE: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

On Wednesday, March 29, 2017, Linus Walleij: > If you prefer to use preprocessor macros or whatever to make the bitmasks > or how you want to organize the constants in your include files is not my > concern, do whatever you seem fit, just pack it into a 32bit thing somehow > which makes sense from

RE: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

On Wednesday, March 29, 2017, Linus Walleij: > If you prefer to use preprocessor macros or whatever to make the bitmasks > or how you want to organize the constants in your include files is not my > concern, do whatever you seem fit, just pack it into a 32bit thing somehow > which makes sense from

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

On Wed, Mar 29, 2017 at 2:38 PM, Chris Brandt wrote: >> I'm strongly in favour of something like >> pinmux = , ; >> >> opposed to >> pinmux = , ... ; > > > I agree. I like "". I

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

On Wed, Mar 29, 2017 at 2:38 PM, Chris Brandt wrote: >> I'm strongly in favour of something like >> pinmux = , ; >> >> opposed to >> pinmux = , ... ; > > > I agree. I like "". I don't know if you have seen the Mediatek things really. include/dt-bindings/pinctrl/mt6397-pinfunc.h

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

On Wed, Mar 29, 2017 at 1:20 PM, Geert Uytterhoeven wrote: >> I do not understand the notion of "flags" here. I hope that is not referring > > Flags refers to BI_DIR, SWIO_IN, and SWIO_OUT, from > https://patchwork.kernel.org/patch/9643047/ Aha I will go in and review that

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

On Wed, Mar 29, 2017 at 1:20 PM, Geert Uytterhoeven wrote: >> I do not understand the notion of "flags" here. I hope that is not referring > > Flags refers to BI_DIR, SWIO_IN, and SWIO_OUT, from > https://patchwork.kernel.org/patch/9643047/ Aha I will go in and review that closer because it

RE: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

Adding my 2 cents here: On Wednesday, March 29, 2017, jacopo wrote: > > > If you really do we may need to go for u64 but ... really? Is there > > > a rational reason for that other than "we did it like this first"? > > > > > > I do not understand the notion of "flags" here. I hope that is not > >

RE: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

Adding my 2 cents here: On Wednesday, March 29, 2017, jacopo wrote: > > > If you really do we may need to go for u64 but ... really? Is there > > > a rational reason for that other than "we did it like this first"? > > > > > > I do not understand the notion of "flags" here. I hope that is not > >

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

Hi Geert, Linus On Wed, Mar 29, 2017 at 01:20:39PM +0200, Geert Uytterhoeven wrote: > Hi Linus, > > On Wed, Mar 29, 2017 at 12:15 PM, Linus Walleij > wrote: > > On Wed, Mar 29, 2017 at 9:35 AM, Geert Uytterhoeven > > wrote: > >>> See for example:

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

Hi Geert, Linus On Wed, Mar 29, 2017 at 01:20:39PM +0200, Geert Uytterhoeven wrote: > Hi Linus, > > On Wed, Mar 29, 2017 at 12:15 PM, Linus Walleij > wrote: > > On Wed, Mar 29, 2017 at 9:35 AM, Geert Uytterhoeven > > wrote: > >>> See for example: > >>> include/dt-bindings/pinctrl/mt65xx.h >

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

Hi Linus, On Wed, Mar 29, 2017 at 12:15 PM, Linus Walleij wrote: > On Wed, Mar 29, 2017 at 9:35 AM, Geert Uytterhoeven > wrote: >>> See for example: >>> include/dt-bindings/pinctrl/mt65xx.h >>> >>> And how that is used in: >>>

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

Hi Linus, On Wed, Mar 29, 2017 at 12:15 PM, Linus Walleij wrote: > On Wed, Mar 29, 2017 at 9:35 AM, Geert Uytterhoeven > wrote: >>> See for example: >>> include/dt-bindings/pinctrl/mt65xx.h >>> >>> And how that is used in: >>> arch/arm/boot/dts/mt2701-pinfunc.h >>>

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

On Wed, Mar 29, 2017 at 9:35 AM, Geert Uytterhoeven wrote: > Me: >> See for example: >> include/dt-bindings/pinctrl/mt65xx.h >> >> And how that is used in: >> arch/arm/boot/dts/mt2701-pinfunc.h >> arch/arm/boot/dts/mt2701-evb.dts >> >> The docs are here: >>

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

On Wed, Mar 29, 2017 at 9:35 AM, Geert Uytterhoeven wrote: > Me: >> See for example: >> include/dt-bindings/pinctrl/mt65xx.h >> >> And how that is used in: >> arch/arm/boot/dts/mt2701-pinfunc.h >> arch/arm/boot/dts/mt2701-evb.dts >> >> The docs are here: >>

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

Hi Linus, On Wed, Mar 29, 2017 at 4:30 AM, Linus Walleij wrote: > On Tue, Mar 28, 2017 at 4:38 PM, wrote: >>> The fact that historically all the early adopters of pinctrl in device >>> tree >>> have these funky custom bindings is unfortunate but

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

Hi Linus, On Wed, Mar 29, 2017 at 4:30 AM, Linus Walleij wrote: > On Tue, Mar 28, 2017 at 4:38 PM, wrote: >>> The fact that historically all the early adopters of pinctrl in device >>> tree >>> have these funky custom bindings is unfortunate but just something >>> that we need to live with. >>

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

On Tue, Mar 28, 2017 at 4:38 PM, wrote: >> The fact that historically all the early adopters of pinctrl in device >> tree >> have these funky custom bindings is unfortunate but just something >> that we need to live with. >> > > To avoid any confusion, please bear with me and

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

On Tue, Mar 28, 2017 at 4:38 PM, wrote: >> The fact that historically all the early adopters of pinctrl in device >> tree >> have these funky custom bindings is unfortunate but just something >> that we need to live with. >> > > To avoid any confusion, please bear with me and clarify this once

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

Hi Linus, On 2017-03-28 11:46, Linus Walleij wrote: On Thu, Mar 23, 2017 at 5:02 PM, jacopo wrote: > + Required properties: > +- renesas,pins Just "pins"? You know, I've been thinking about this, bu the "pins" property definition in pinctrl-bidings is the

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

Hi Linus, On 2017-03-28 11:46, Linus Walleij wrote: On Thu, Mar 23, 2017 at 5:02 PM, jacopo wrote: > + Required properties: > +- renesas,pins Just "pins"? You know, I've been thinking about this, bu the "pins" property definition in pinctrl-bidings is the following one:

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

On Thu, Mar 23, 2017 at 5:02 PM, jacopo wrote: >> > + Required properties: >> > +- renesas,pins >> >> Just "pins"? >> > > You know, I've been thinking about this, bu the "pins" property > definition in pinctrl-bidings is the following one: > >

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

On Thu, Mar 23, 2017 at 5:02 PM, jacopo wrote: >> > + Required properties: >> > +- renesas,pins >> >> Just "pins"? >> > > You know, I've been thinking about this, bu the "pins" property > definition in pinctrl-bidings is the following one: > >

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

Hi Geert, thanks for review On Wed, Mar 22, 2017 at 11:33:50AM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Mon, Mar 20, 2017 at 5:14 PM, Jacopo Mondi > wrote: > > Add device tree bindings documentation for Renesas RZ/A1 gpio and pin > > for the Renesas

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

Hi Geert, thanks for review On Wed, Mar 22, 2017 at 11:33:50AM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Mon, Mar 20, 2017 at 5:14 PM, Jacopo Mondi > wrote: > > Add device tree bindings documentation for Renesas RZ/A1 gpio and pin > > for the Renesas ... > > > controller. > > >

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

Hi Jacopo, On Wed, Mar 22, 2017 at 4:36 PM, jacopo wrote: > On Wed, Mar 22, 2017 at 02:20:08PM +0100, Geert Uytterhoeven wrote: >> On Wed, Mar 22, 2017 at 11:33 AM, Geert Uytterhoeven >> wrote: >> > On Mon, Mar 20, 2017 at 5:14 PM, Jacopo Mondi

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

Hi Jacopo, On Wed, Mar 22, 2017 at 4:36 PM, jacopo wrote: > On Wed, Mar 22, 2017 at 02:20:08PM +0100, Geert Uytterhoeven wrote: >> On Wed, Mar 22, 2017 at 11:33 AM, Geert Uytterhoeven >> wrote: >> > On Mon, Mar 20, 2017 at 5:14 PM, Jacopo Mondi >> > wrote: >> >> Add device tree bindings

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

Hi Geert, thanks for reviews On Wed, Mar 22, 2017 at 02:20:08PM +0100, Geert Uytterhoeven wrote: > On Wed, Mar 22, 2017 at 11:33 AM, Geert Uytterhoeven > wrote: > > On Mon, Mar 20, 2017 at 5:14 PM, Jacopo Mondi > > wrote: > >> Add device

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

Hi Geert, thanks for reviews On Wed, Mar 22, 2017 at 02:20:08PM +0100, Geert Uytterhoeven wrote: > On Wed, Mar 22, 2017 at 11:33 AM, Geert Uytterhoeven > wrote: > > On Mon, Mar 20, 2017 at 5:14 PM, Jacopo Mondi > > wrote: > >> Add device tree bindings documentation for Renesas RZ/A1 gpio

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

On Wed, Mar 22, 2017 at 11:33 AM, Geert Uytterhoeven wrote: > On Mon, Mar 20, 2017 at 5:14 PM, Jacopo Mondi > wrote: >> Add device tree bindings documentation for Renesas RZ/A1 gpio and pin >> --- /dev/null >> +++

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

On Wed, Mar 22, 2017 at 11:33 AM, Geert Uytterhoeven wrote: > On Mon, Mar 20, 2017 at 5:14 PM, Jacopo Mondi > wrote: >> Add device tree bindings documentation for Renesas RZ/A1 gpio and pin >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rza1-pinctrl.txt ulating the

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

Hi Jacopo, On Mon, Mar 20, 2017 at 5:14 PM, Jacopo Mondi wrote: > Add device tree bindings documentation for Renesas RZ/A1 gpio and pin for the Renesas ... > controller. > > Signed-off-by: Jacopo Mondi > --- >

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

Hi Jacopo, On Mon, Mar 20, 2017 at 5:14 PM, Jacopo Mondi wrote: > Add device tree bindings documentation for Renesas RZ/A1 gpio and pin for the Renesas ... > controller. > > Signed-off-by: Jacopo Mondi > --- > .../bindings/pinctrl/renesas,rza1-pinctrl.txt | 144 > +