Re: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show register contents

2017-11-28 Thread Andy Shevchenko
On Mon, 2017-11-27 at 20:52 +, Kammela, Gayatri wrote: > > Moreover, see the patch I have just sent [1] and use same > > DEFINE_SHOW_ATTRIBUTE() macro here. In that case we would easily > > move it > > to seq_file.h for everyone to use in the future. > > That makes sense! I see your patch is

Re: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show register contents

2017-11-28 Thread Andy Shevchenko
On Mon, 2017-11-27 at 20:52 +, Kammela, Gayatri wrote: > > Moreover, see the patch I have just sent [1] and use same > > DEFINE_SHOW_ATTRIBUTE() macro here. In that case we would easily > > move it > > to seq_file.h for everyone to use in the future. > > That makes sense! I see your patch is

Re: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show register contents

2017-11-28 Thread Andy Shevchenko
On Tue, 2017-11-28 at 00:02 +, Mehta, Sohil wrote: > On Mon, 2017-11-27 at 20:52 +, Kammela, Gayatri wrote: > > > > > > > > From: Andy Shevchenko [mailto:andriy.shevche...@linux.intel.com] > > > Sent: Wednesday, November 22, 2017 1:19 PM > > > > > > Moreover, see the patch I have just

Re: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show register contents

2017-11-28 Thread Andy Shevchenko
On Tue, 2017-11-28 at 00:02 +, Mehta, Sohil wrote: > On Mon, 2017-11-27 at 20:52 +, Kammela, Gayatri wrote: > > > > > > > > From: Andy Shevchenko [mailto:andriy.shevche...@linux.intel.com] > > > Sent: Wednesday, November 22, 2017 1:19 PM > > > > > > Moreover, see the patch I have just

Re: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show register contents

2017-11-27 Thread Mehta, Sohil
On Mon, 2017-11-27 at 20:52 +, Kammela, Gayatri wrote: > > > > > From: Andy Shevchenko [mailto:andriy.shevche...@linux.intel.com] > > Sent: Wednesday, November 22, 2017 1:19 PM > >  > > Moreover, see the patch I have just sent [1] and use same > > DEFINE_SHOW_ATTRIBUTE() macro here. In that

Re: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show register contents

2017-11-27 Thread Mehta, Sohil
On Mon, 2017-11-27 at 20:52 +, Kammela, Gayatri wrote: > > > > > From: Andy Shevchenko [mailto:andriy.shevche...@linux.intel.com] > > Sent: Wednesday, November 22, 2017 1:19 PM > >  > > Moreover, see the patch I have just sent [1] and use same > > DEFINE_SHOW_ATTRIBUTE() macro here. In that

RE: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show register contents

2017-11-27 Thread Kammela, Gayatri
<ravi.v.shan...@intel.com>; Yu, Fenghua <fenghua...@intel.com> > Subject: Re: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show > register contents > > On Wed, 2017-11-22 at 11:25 -0800, Sohil Mehta wrote: > > From: Gayatri Kammela <gayatri.

RE: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show register contents

2017-11-27 Thread Kammela, Gayatri
ion.org; linux- > ker...@vger.kernel.org; Jacob Pan ; Kammela, > Gayatri ; Shankar, Ravi V > ; Yu, Fenghua > Subject: Re: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show > register contents > > On Wed, 2017-11-22 at 11:25 -0800, Sohil Mehta wrote: > > From: Gayatri Kammela &g

Re: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show register contents

2017-11-22 Thread Andy Shevchenko
On Wed, 2017-11-22 at 11:25 -0800, Sohil Mehta wrote: > From: Gayatri Kammela > +static int intel_iommu_regs_open(struct inode *inode, struct file > *file) > +{ > + return single_open(file, intel_iommu_debugfs_regs_show, > +

Re: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show register contents

2017-11-22 Thread Andy Shevchenko
On Wed, 2017-11-22 at 11:25 -0800, Sohil Mehta wrote: > From: Gayatri Kammela > +static int intel_iommu_regs_open(struct inode *inode, struct file > *file) > +{ > + return single_open(file, intel_iommu_debugfs_regs_show, > +inode->i_private); > +} > + > +static const