Re: [PATCH v2 6/8] ntb_tool: Add link status and files to debugfs

2016-06-15 Thread Logan Gunthorpe
On 15/06/16 10:02 AM, Allen Hubbe wrote: >> My understanding is that ntb_tool is really just a test client to verify >> the API and the hardware. I personally would not recommend it for any >> real applications. As such, I don't think this philosophical argument >> really matches that goal. > >

Re: [PATCH v2 6/8] ntb_tool: Add link status and files to debugfs

2016-06-15 Thread Logan Gunthorpe
On 15/06/16 10:02 AM, Allen Hubbe wrote: >> My understanding is that ntb_tool is really just a test client to verify >> the API and the hardware. I personally would not recommend it for any >> real applications. As such, I don't think this philosophical argument >> really matches that goal. > >

RE: [PATCH v2 6/8] ntb_tool: Add link status and files to debugfs

2016-06-15 Thread Allen Hubbe
From: Logan Gunthorpe > On 14/06/16 03:46 PM, Allen Hubbe wrote: > > The ntb_tool is intended to be a simple low level access to the ntb.h api. > > As much as > possible, I think ntb_tool should directly expose the ntb.h api through > debugfs, and not > invent higher level concepts. > > I

RE: [PATCH v2 6/8] ntb_tool: Add link status and files to debugfs

2016-06-15 Thread Allen Hubbe
From: Logan Gunthorpe > On 14/06/16 03:46 PM, Allen Hubbe wrote: > > The ntb_tool is intended to be a simple low level access to the ntb.h api. > > As much as > possible, I think ntb_tool should directly expose the ntb.h api through > debugfs, and not > invent higher level concepts. > > I

Re: [PATCH v2 6/8] ntb_tool: Add link status and files to debugfs

2016-06-14 Thread Logan Gunthorpe
On 14/06/16 03:46 PM, Allen Hubbe wrote: > The ntb_tool is intended to be a simple low level access to the ntb.h api. > As much as possible, I think ntb_tool should directly expose the ntb.h api > through debugfs, and not invent higher level concepts. I really think practical concerns should

Re: [PATCH v2 6/8] ntb_tool: Add link status and files to debugfs

2016-06-14 Thread Logan Gunthorpe
On 14/06/16 03:46 PM, Allen Hubbe wrote: > The ntb_tool is intended to be a simple low level access to the ntb.h api. > As much as possible, I think ntb_tool should directly expose the ntb.h api > through debugfs, and not invent higher level concepts. I really think practical concerns should

RE: [PATCH v2 6/8] ntb_tool: Add link status and files to debugfs

2016-06-14 Thread Allen Hubbe
From: Logan Gunthorpe > On 14/06/16 01:33 PM, Allen Hubbe wrote: > >> diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c > >> index cba31fd..9bebd0d 100644 > >> --- a/drivers/ntb/test/ntb_tool.c > >> +++ b/drivers/ntb/test/ntb_tool.c > >> @@ -59,6 +59,13 @@ > >> * > >> *

RE: [PATCH v2 6/8] ntb_tool: Add link status and files to debugfs

2016-06-14 Thread Allen Hubbe
From: Logan Gunthorpe > On 14/06/16 01:33 PM, Allen Hubbe wrote: > >> diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c > >> index cba31fd..9bebd0d 100644 > >> --- a/drivers/ntb/test/ntb_tool.c > >> +++ b/drivers/ntb/test/ntb_tool.c > >> @@ -59,6 +59,13 @@ > >> * > >> *

Re: [PATCH v2 6/8] ntb_tool: Add link status and files to debugfs

2016-06-14 Thread Logan Gunthorpe
On 14/06/16 01:33 PM, Allen Hubbe wrote: >> diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c >> index cba31fd..9bebd0d 100644 >> --- a/drivers/ntb/test/ntb_tool.c >> +++ b/drivers/ntb/test/ntb_tool.c >> @@ -59,6 +59,13 @@ >> * >> * Eg: check if clearing the doorbell

Re: [PATCH v2 6/8] ntb_tool: Add link status and files to debugfs

2016-06-14 Thread Logan Gunthorpe
On 14/06/16 01:33 PM, Allen Hubbe wrote: >> diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c >> index cba31fd..9bebd0d 100644 >> --- a/drivers/ntb/test/ntb_tool.c >> +++ b/drivers/ntb/test/ntb_tool.c >> @@ -59,6 +59,13 @@ >> * >> * Eg: check if clearing the doorbell

RE: [PATCH v2 6/8] ntb_tool: Add link status and files to debugfs

2016-06-14 Thread Allen Hubbe
From: Logan Gunthorpe > In order to more successfully script with ntb_tool it's useful to > have a link file to check the link status so that the script > doesn't use the other files until the link is up. > > This commit adds a 'link' file to the debugfs directory which reads a > boolean (Y or N)

RE: [PATCH v2 6/8] ntb_tool: Add link status and files to debugfs

2016-06-14 Thread Allen Hubbe
From: Logan Gunthorpe > In order to more successfully script with ntb_tool it's useful to > have a link file to check the link status so that the script > doesn't use the other files until the link is up. > > This commit adds a 'link' file to the debugfs directory which reads a > boolean (Y or N)