RE: RE: RE: RE: [PATCH v22 2/4] scsi: ufs: L2P map management for HPB read

2021-02-23 Thread Daejun Park
> > > > +/* > > > > + * This function will parse recommended active subregion information in > > > > sense > > > > + * data field of response UPIU with SAM_STAT_GOOD state. > > > > + */ > > > > +void ufshpb_rsp_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp) > > > > +{ > > > > + struct

RE: RE: RE: [PATCH v22 2/4] scsi: ufs: L2P map management for HPB read

2021-02-23 Thread Avri Altman
> > > +/* > > > + * This function will parse recommended active subregion information in > > > sense > > > + * data field of response UPIU with SAM_STAT_GOOD state. > > > + */ > > > +void ufshpb_rsp_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp) > > > +{ > > > + struct ufshpb_lu *hpb; >

RE: RE: RE: [PATCH v22 2/4] scsi: ufs: L2P map management for HPB read

2021-02-23 Thread Daejun Park
> +/* > > + * This function will parse recommended active subregion information in > > sense > > + * data field of response UPIU with SAM_STAT_GOOD state. > > + */ > > +void ufshpb_rsp_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp) > > +{ > > +   struct ufshpb_lu *hpb; > > +   struct 

RE: RE: [PATCH v22 2/4] scsi: ufs: L2P map management for HPB read

2021-02-23 Thread Daejun Park
> > + if (!ufshpb_is_hpb_rsp_valid(hba, lrbp, rsp_field)) > > + return; > > + > > + hpb->stats.rb_noti_cnt++; > > > + switch (rsp_field->hpb_op) { > > + case HPB_RSP_NONE: > > + /* nothing to do */ > > + break; > Maybe checks this

RE: RE: [PATCH v22 2/4] scsi: ufs: L2P map management for HPB read

2021-02-23 Thread Daejun Park
> +/* > > + * This function will parse recommended active subregion information in > > sense > > + * data field of response UPIU with SAM_STAT_GOOD state. > > + */ > > +void ufshpb_rsp_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp) > > +{ > > + struct ufshpb_lu *hpb; > > + struct

RE: [PATCH v22 2/4] scsi: ufs: L2P map management for HPB read

2021-02-22 Thread Avri Altman
> + if (!ufshpb_is_hpb_rsp_valid(hba, lrbp, rsp_field)) > + return; > + > + hpb->stats.rb_noti_cnt++; > + switch (rsp_field->hpb_op) { > + case HPB_RSP_NONE: > + /* nothing to do */ > + break; Maybe checks this too in

RE: [PATCH v22 2/4] scsi: ufs: L2P map management for HPB read

2021-02-22 Thread Avri Altman
> +/* > + * This function will parse recommended active subregion information in > sense > + * data field of response UPIU with SAM_STAT_GOOD state. > + */ > +void ufshpb_rsp_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp) > +{ > + struct ufshpb_lu *hpb; > + struct scsi_device