RE: [PATCH v3] gpio: mpc8xxx: Add ACPI support

2021-03-21 Thread Ran Wang
Hi Andy, On Friday, March 19, 2021 6:32 PM, Andy Shevchenko wrote: > > On Fri, Mar 19, 2021 at 10:10 AM Ran Wang wrote: > > > > Current implementation only supports DT, now add ACPI support. > > Thanks for an update, my comments below. > > ... > > > +#include > > Missed > property.h > mod_d

Re: [PATCH v3] gpio: mpc8xxx: Add ACPI support

2021-03-19 Thread Andy Shevchenko
On Fri, Mar 19, 2021 at 10:10 AM Ran Wang wrote: > > Current implementation only supports DT, now add ACPI support. Thanks for an update, my comments below. ... > +#include Missed property.h mod_devicetable.h. ... > - mpc8xxx_gc->regs = of_iomap(np, 0); > + mpc8xxx_gc->regs = de