Re: [PATCH v3 1/2] mfd: da9063: Fix revision handling to correctly select reg tables

2020-06-18 Thread Lee Jones
On Thu, 18 Jun 2020, Adam Thomson wrote: > On 18 June 2020 12:15, Lee Jones wrote: > > > > > > The current implementation performs checking in the i2c_probe() > > > > > function of the variant_code but does this immediately after the > > > > > containing struct has been initialised as all zero.

RE: [PATCH v3 1/2] mfd: da9063: Fix revision handling to correctly select reg tables

2020-06-18 Thread Adam Thomson
On 18 June 2020 12:15, Lee Jones wrote: > > > > The current implementation performs checking in the i2c_probe() > > > > function of the variant_code but does this immediately after the > > > > containing struct has been initialised as all zero. This means the > > > > check for variant code will

Re: [PATCH v3 1/2] mfd: da9063: Fix revision handling to correctly select reg tables

2020-06-18 Thread Lee Jones
On Thu, 18 Jun 2020, Adam Thomson wrote: > On 18 June 2020 11:15, Lee Jones wrote: > > > > The current implementation performs checking in the i2c_probe() > > > function of the variant_code but does this immediately after the > > > containing struct has been initialised as all zero. This means

RE: [PATCH v3 1/2] mfd: da9063: Fix revision handling to correctly select reg tables

2020-06-18 Thread Adam Thomson
On 18 June 2020 11:15, Lee Jones wrote: > > The current implementation performs checking in the i2c_probe() > > function of the variant_code but does this immediately after the > > containing struct has been initialised as all zero. This means the > > check for variant code will always default to

Re: [PATCH v3 1/2] mfd: da9063: Fix revision handling to correctly select reg tables

2020-06-18 Thread Lee Jones
On Fri, 17 Apr 2020, Adam Thomson wrote: > The current implementation performs checking in the i2c_probe() > function of the variant_code but does this immediately after the > containing struct has been initialised as all zero. This means the > check for variant code will always default to using