RE: [PATCH v3 2/3] clocksource: update "fn" at CLOCKSOURCE_OF_DECLARE() of nps400 timer

2016-11-01 Thread Noam Camus
> From: Thomas Gleixner [mailto:t...@linutronix.de] > Sent: Monday, October 31, 2016 7:40 PM >> >> static unsigned long nps_timer_rate; >> +static int nps_get_timer_clk(struct device_node *node, > >Please don't glue variables and functions together w/o a new line. That's >horrible to read.

RE: [PATCH v3 2/3] clocksource: update "fn" at CLOCKSOURCE_OF_DECLARE() of nps400 timer

2016-11-01 Thread Noam Camus
> From: Thomas Gleixner [mailto:t...@linutronix.de] > Sent: Monday, October 31, 2016 7:40 PM >> >> static unsigned long nps_timer_rate; >> +static int nps_get_timer_clk(struct device_node *node, > >Please don't glue variables and functions together w/o a new line. That's >horrible to read.

Re: [PATCH v3 2/3] clocksource: update "fn" at CLOCKSOURCE_OF_DECLARE() of nps400 timer

2016-10-31 Thread Thomas Gleixner
On Mon, 31 Oct 2016, Noam Camus wrote: > > static unsigned long nps_timer_rate; > +static int nps_get_timer_clk(struct device_node *node, Please don't glue variables and functions together w/o a new line. That's horrible to read. > +static int __init nps_setup_clocksource(struct device_node

Re: [PATCH v3 2/3] clocksource: update "fn" at CLOCKSOURCE_OF_DECLARE() of nps400 timer

2016-10-31 Thread Thomas Gleixner
On Mon, 31 Oct 2016, Noam Camus wrote: > > static unsigned long nps_timer_rate; > +static int nps_get_timer_clk(struct device_node *node, Please don't glue variables and functions together w/o a new line. That's horrible to read. > +static int __init nps_setup_clocksource(struct device_node