RE: [PATCH v3 2/4] input: Cypress PS/2 Trackpad psmouse driver

2012-12-04 Thread Dudley Du
Hi Henrik, Kamal, Thanks for your review. And I add some comments in below. Thanks. Dudley Du d...@cypress.com > Hi Henrik- > > Thanks again for your review. The forthcoming PATCH v4 includes the majority > of your change requests, except where noted below (and considering my email > "Subject

Re: [PATCH v3 2/4] input: Cypress PS/2 Trackpad psmouse driver

2012-12-04 Thread Kamal Mostafa
Hi Henrik- Thanks again for your review. The forthcoming PATCH v4 includes the majority of your change requests, except where noted below (and considering my email "Subject: SEMI_MT vs. simulated mt")... On Mon, 2012-12-03 at 08:45 +0100, Henrik Rydberg wrote: > > + /* > > +

Re: [PATCH v3 2/4] input: Cypress PS/2 Trackpad psmouse driver

2012-12-03 Thread Dmitry Torokhov
On Mon, Dec 03, 2012 at 08:45:20AM +0100, Henrik Rydberg wrote: > > +/* > > + * reset trackpad device to standard relative mode. > > + * This is also the defalut mode when trackpad powered on. > > + */ > > +static void cypress_reset(struct psmouse *psmouse) > > +{ > > + struct cytp_data *cytp = p

Re: [PATCH v3 2/4] input: Cypress PS/2 Trackpad psmouse driver

2012-12-02 Thread Henrik Rydberg
Hi Kamal, > From: Cypress Semiconductor Corporation > > Input/mouse driver for Cypress PS/2 Trackpad. > > Original code contributed by Cypress Semiconductor Corporation, > modified by Kamal Mostafa and Kyle Fazzari. > > BugLink: http://launchpad.net/bugs/978807 > > Signed-off-by: Kamal Mostaf

RE: [PATCH v3 2/4] input: Cypress PS/2 Trackpad psmouse driver

2012-12-02 Thread Dudley Du
Torokhov; David Solda; Troy Abercrombia; customercare; Kyle Fazzari; Mario Limonciello; Tim Gardner; Herton Krzesinski; d...@cyress.com Subject: Re: [PATCH v3 2/4] input: Cypress PS/2 Trackpad psmouse driver Hi Dudley, > Another question is that new interface input_mt_assign_slots() is > intr

Re: [PATCH v3 2/4] input: Cypress PS/2 Trackpad psmouse driver

2012-12-02 Thread Henrik Rydberg
Hi Dudley, > Another question is that new interface input_mt_assign_slots() is introduced > since 3.7-rc7 or later, > So we could not support the kernel releases that earlier than 3.7-rc7 with > this driver. The patch is a submission to mainline, so of course it should be in sync with mainline

RE: [PATCH v3 2/4] input: Cypress PS/2 Trackpad psmouse driver

2012-12-02 Thread Dudley Du
n...@vger.kernel.org; linux-kernel@vger.kernel.org; Dmitry Torokhov; Henrik Rydberg Cc: David Solda; Troy Abercrombia; customercare; Kyle Fazzari; Mario Limonciello; Tim Gardner; Herton Krzesinski; 'd...@cyress.com' Subject: RE: [PATCH v3 2/4] input: Cypress PS/2 Trackpad psmouse driver

RE: [PATCH v3 2/4] input: Cypress PS/2 Trackpad psmouse driver

2012-12-02 Thread Dudley Du
Hi Kamal, I'm the writer of this driver. Thanks for help upstream this driver. I noticed that you marked out the reconnect function for it never work at all. But in my test, it seems work fine. I do the test steps as below: 1. load this driver with Cypress trackpad. Cursor moving on system; 2. di