Re: [PATCH v4 0/1] Add support for IPMB driver

2019-05-02 Thread Corey Minyard
On Thu, May 02, 2019 at 09:14:46PM +, Vadim Pasternak wrote: > [...] > > > > > > >>Better, if you can avoid cast. > > > >>Would compiler warn if you use for example rol16(client->addr, 1) & > > GENMASK(7, 0); or something like it? > > > I thought it wouldn't be too much of an issue to use

RE: [PATCH v4 0/1] Add support for IPMB driver

2019-05-02 Thread Vadim Pasternak
[...] > > > > >>Better, if you can avoid cast. > > >>Would compiler warn if you use for example rol16(client->addr, 1) & > GENMASK(7, 0); or something like it? > > I thought it wouldn't be too much of an issue to use typecast here since > > other > existing ipmi drivers use typecasting:

RE: [PATCH v4 0/1] Add support for IPMB driver

2019-05-02 Thread Asmaa Mnebhi
PM > To: Asmaa Mnebhi ; miny...@acm.org; > w...@the-dreams.de; Michael Shych > Cc: Asmaa Mnebhi ; linux-kernel@vger.kernel.org; > linux-...@vger.kernel.org > Subject: RE: [PATCH v4 0/1] Add support for IPMB driver > > > > > -Original Message- > > F

Re: [PATCH v4 0/1] Add support for IPMB driver

2019-05-02 Thread Corey Minyard
.org; w...@the-dreams.de; > Michael Shych > Cc: Asmaa Mnebhi ; linux-kernel@vger.kernel.org; > linux-...@vger.kernel.org > Subject: RE: [PATCH v4 0/1] Add support for IPMB driver > > > > > -Original Message- > > From: Asmaa Mnebhi > > S

RE: [PATCH v4 0/1] Add support for IPMB driver

2019-05-02 Thread Asmaa Mnebhi
-...@vger.kernel.org Subject: RE: [PATCH v4 0/1] Add support for IPMB driver > -Original Message- > From: Asmaa Mnebhi > Sent: Tuesday, April 30, 2019 8:59 PM > To: miny...@acm.org; w...@the-dreams.de; Vadim Pasternak > ; Michael Shych > Cc: Asmaa Mnebhi ; linux-kern

Re: [PATCH v4 0/1] Add support for IPMB driver

2019-04-30 Thread Corey Minyard
On Tue, Apr 30, 2019 at 09:24:29PM +, Vadim Pasternak wrote: > > > > -Original Message- > > From: Asmaa Mnebhi > > Sent: Tuesday, April 30, 2019 8:59 PM > > To: miny...@acm.org; w...@the-dreams.de; Vadim Pasternak > > ; Michael Shych > > Cc: Asmaa Mnebhi ;

RE: [PATCH v4 0/1] Add support for IPMB driver

2019-04-30 Thread Vadim Pasternak
> -Original Message- > From: Asmaa Mnebhi > Sent: Tuesday, April 30, 2019 8:59 PM > To: miny...@acm.org; w...@the-dreams.de; Vadim Pasternak > ; Michael Shych > Cc: Asmaa Mnebhi ; linux-kernel@vger.kernel.org; > linux-...@vger.kernel.org > Subject: [PATCH v4 0/1] Add support for IPMB