RE: [PATCH v4 07/12] [media] cxd2880: Add top level of the driver

Hi, Mauro > > + > > +#define pr_fmt(fmt) KBUILD_MODNAME ": %s: " fmt, __func__ > > Same comments as on other patches: use SPDX and dev_foo() for printing > messages. About printing messages pr_fmt, I also replied a comment to [PATCH v4 02/12] [media] cxd2880-spi: Add support for CXD2880 SPI

RE: [PATCH v4 07/12] [media] cxd2880: Add top level of the driver

Hi, Mauro > > + > > +#define pr_fmt(fmt) KBUILD_MODNAME ": %s: " fmt, __func__ > > Same comments as on other patches: use SPDX and dev_foo() for printing > messages. About printing messages pr_fmt, I also replied a comment to [PATCH v4 02/12] [media] cxd2880-spi: Add support for CXD2880 SPI

Re: [PATCH v4 07/12] [media] cxd2880: Add top level of the driver

Em Fri, 13 Oct 2017 15:09:34 +0900 escreveu: > From: Yasunari Takiguchi > > This provides the main dvb frontend operation functions > for the Sony CXD2880 DVB-T2/T tuner + demodulator driver. > > Signed-off-by: Yasunari Takiguchi

Re: [PATCH v4 07/12] [media] cxd2880: Add top level of the driver

Em Fri, 13 Oct 2017 15:09:34 +0900 escreveu: > From: Yasunari Takiguchi > > This provides the main dvb frontend operation functions > for the Sony CXD2880 DVB-T2/T tuner + demodulator driver. > > Signed-off-by: Yasunari Takiguchi > Signed-off-by: Masayuki Yamamoto > Signed-off-by: Hideki

RE: [PATCH v4 07/12] [media] cxd2880: Add top level of the driver

Dear Sean Hi, Thanks for your review. We will refer to your comments and consider how to respond for them. > > + u8 rdata[2]; > > + int ret; > > + > > + if ((!tnrdmd) || (!pre_bit_err) || (!pre_bit_count)) > > + return -EINVAL; > > + > > + if (tnrdmd->diver_mode ==

RE: [PATCH v4 07/12] [media] cxd2880: Add top level of the driver

Dear Sean Hi, Thanks for your review. We will refer to your comments and consider how to respond for them. > > + u8 rdata[2]; > > + int ret; > > + > > + if ((!tnrdmd) || (!pre_bit_err) || (!pre_bit_count)) > > + return -EINVAL; > > + > > + if (tnrdmd->diver_mode ==

Re: [PATCH v4 07/12] [media] cxd2880: Add top level of the driver

Hello, Many thanks for the driver. The ./scripts/checkpatch.pl with --strict has many warnings, some of which might be nice to have cleaned up. There are some very minor comments below. Similar constructs are in other files too. After reading and understanding through all the code, I think

Re: [PATCH v4 07/12] [media] cxd2880: Add top level of the driver

Hello, Many thanks for the driver. The ./scripts/checkpatch.pl with --strict has many warnings, some of which might be nice to have cleaned up. There are some very minor comments below. Similar constructs are in other files too. After reading and understanding through all the code, I think