Re: [PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-19 Thread Kirill A. Shutemov
On Thu, Sep 19, 2019 at 03:41:43PM +, Catalin Marinas wrote: > On Thu, Sep 19, 2019 at 06:00:07PM +0300, Kirill A. Shutemov wrote: > > On Wed, Sep 18, 2019 at 07:00:30PM +0100, Catalin Marinas wrote: > > > On Wed, Sep 18, 2019 at 05:00:27PM +0300, Kirill A. Shutemov wrote: > > > > On Wed, Sep

Re: [PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-19 Thread Catalin Marinas
On Thu, Sep 19, 2019 at 06:00:07PM +0300, Kirill A. Shutemov wrote: > On Wed, Sep 18, 2019 at 07:00:30PM +0100, Catalin Marinas wrote: > > On Wed, Sep 18, 2019 at 05:00:27PM +0300, Kirill A. Shutemov wrote: > > > On Wed, Sep 18, 2019 at 09:19:14PM +0800, Jia He wrote: > > > > @@ -2152,20 +2163,34

RE: [PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-19 Thread Justin He (Arm Technology China)
Hi Kirill Thanks for the detailed explanation. -- Cheers, Justin (Jia He) > -Original Message- > From: Kirill A. Shutemov > Sent: 2019年9月19日 22:58 > To: Jia He > Cc: Justin He (Arm Technology China) ; Catalin > Marinas ; Will Deacon ; Mark > Rutland ; James Morse > ; Marc Zyngier ;

Re: [PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-19 Thread Kirill A. Shutemov
On Wed, Sep 18, 2019 at 07:00:30PM +0100, Catalin Marinas wrote: > On Wed, Sep 18, 2019 at 05:00:27PM +0300, Kirill A. Shutemov wrote: > > On Wed, Sep 18, 2019 at 09:19:14PM +0800, Jia He wrote: > > > @@ -2152,20 +2163,34 @@ static inline void cow_user_page(struct page > > > *dst, struct page

Re: [PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-19 Thread Kirill A. Shutemov
On Thu, Sep 19, 2019 at 10:16:34AM +0800, Jia He wrote: > Hi Kirill > > [On behalf of justin...@arm.com because some mails are filted...] > > On 2019/9/18 22:00, Kirill A. Shutemov wrote: > > On Wed, Sep 18, 2019 at 09:19:14PM +0800, Jia He wrote: > > > When we tested pmdk unit test [1]

Re: [PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-18 Thread Jia He
Hi Kirill [On behalf of justin...@arm.com because some mails are filted...] On 2019/9/18 22:00, Kirill A. Shutemov wrote: On Wed, Sep 18, 2019 at 09:19:14PM +0800, Jia He wrote: When we tested pmdk unit test [1] vmmalloc_fork TEST1 in arm64 guest, there will be a double page fault in

RE: [PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-18 Thread Justin He (Arm Technology China)
> -Original Message- > From: kbuild test robot > Sent: 2019年9月19日 3:36 > To: Justin He (Arm Technology China) > Cc: kbuild-...@01.org; Catalin Marinas ; Will > Deacon ; Mark Rutland ; > James Morse ; Marc Zyngier ; > Matthew Wilcox ; Kirill A. Shutemov > ;

Re: [PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-18 Thread kbuild test robot
Hi Jia, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3 next-20190917] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-18 Thread Catalin Marinas
On Wed, Sep 18, 2019 at 05:00:27PM +0300, Kirill A. Shutemov wrote: > On Wed, Sep 18, 2019 at 09:19:14PM +0800, Jia He wrote: > > @@ -2152,20 +2163,34 @@ static inline void cow_user_page(struct page *dst, > > struct page *src, unsigned lo > > */ > > if (unlikely(!src)) { > >

Re: [PATCH v4 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-18 Thread Kirill A. Shutemov
On Wed, Sep 18, 2019 at 09:19:14PM +0800, Jia He wrote: > When we tested pmdk unit test [1] vmmalloc_fork TEST1 in arm64 guest, there > will be a double page fault in __copy_from_user_inatomic of cow_user_page. > > Below call trace is from arm64 do_page_fault for debugging purpose > [