Re: [PATCH v5 16/17] tpm: take TPM chip power gating out of tpm_transmit()

2018-11-13 Thread Jarkko Sakkinen
On Tue, Nov 13, 2018 at 11:58:58AM +, Winkler, Tomas wrote: > Yes, w/o this constrain it would be okay to request locality only once, > we can ask tboot ask again but at the time the requirement was that locality > can be taken of at any point, > I believe that the locality won't be granted

Re: [PATCH v5 16/17] tpm: take TPM chip power gating out of tpm_transmit()

2018-11-13 Thread Jarkko Sakkinen
On Tue, Nov 13, 2018 at 11:58:58AM +, Winkler, Tomas wrote: > Yes, w/o this constrain it would be okay to request locality only once, > we can ask tboot ask again but at the time the requirement was that locality > can be taken of at any point, > I believe that the locality won't be granted

RE: [PATCH v5 16/17] tpm: take TPM chip power gating out of tpm_transmit()

2018-11-13 Thread Winkler, Tomas
deusz ; Stefan Berger > ; Nayna Jain ; Peter > Huewe ; Jason Gunthorpe ; Arnd > Bergmann ; Greg Kroah-Hartman > ; open list > Subject: Re: [PATCH v5 16/17] tpm: take TPM chip power gating out of > tpm_transmit() > > On Fri, Nov 09, 2018 at 09:37:48PM +, Winkler, Tomas wrote: &

RE: [PATCH v5 16/17] tpm: take TPM chip power gating out of tpm_transmit()

2018-11-13 Thread Winkler, Tomas
deusz ; Stefan Berger > ; Nayna Jain ; Peter > Huewe ; Jason Gunthorpe ; Arnd > Bergmann ; Greg Kroah-Hartman > ; open list > Subject: Re: [PATCH v5 16/17] tpm: take TPM chip power gating out of > tpm_transmit() > > On Fri, Nov 09, 2018 at 09:37:48PM +, Winkler, Tomas wrote: &

Re: [PATCH v5 16/17] tpm: take TPM chip power gating out of tpm_transmit()

2018-11-13 Thread Jarkko Sakkinen
On Fri, Nov 09, 2018 at 09:37:48PM +, Winkler, Tomas wrote: > > On Thu, Nov 08, 2018 at 06:38:59PM +, Winkler, Tomas wrote: > > > > Call tpm_chip_start() and tpm_chip_stop() in > > > > > > > > * tpm_try_get_ops() and tpm_put_ops() > > > > * tpm_chip_register() > > > > * tpm2_del_space() >

Re: [PATCH v5 16/17] tpm: take TPM chip power gating out of tpm_transmit()

2018-11-13 Thread Jarkko Sakkinen
On Fri, Nov 09, 2018 at 09:37:48PM +, Winkler, Tomas wrote: > > On Thu, Nov 08, 2018 at 06:38:59PM +, Winkler, Tomas wrote: > > > > Call tpm_chip_start() and tpm_chip_stop() in > > > > > > > > * tpm_try_get_ops() and tpm_put_ops() > > > > * tpm_chip_register() > > > > * tpm2_del_space() >

RE: [PATCH v5 16/17] tpm: take TPM chip power gating out of tpm_transmit()

2018-11-09 Thread Winkler, Tomas
> > On Thu, Nov 08, 2018 at 06:38:59PM +, Winkler, Tomas wrote: > > > Call tpm_chip_start() and tpm_chip_stop() in > > > > > > * tpm_try_get_ops() and tpm_put_ops() > > > * tpm_chip_register() > > > * tpm2_del_space() > > > > > > And remove these calls from tpm_transmit(). The core reason

RE: [PATCH v5 16/17] tpm: take TPM chip power gating out of tpm_transmit()

2018-11-09 Thread Winkler, Tomas
> > On Thu, Nov 08, 2018 at 06:38:59PM +, Winkler, Tomas wrote: > > > Call tpm_chip_start() and tpm_chip_stop() in > > > > > > * tpm_try_get_ops() and tpm_put_ops() > > > * tpm_chip_register() > > > * tpm2_del_space() > > > > > > And remove these calls from tpm_transmit(). The core reason

Re: [PATCH v5 16/17] tpm: take TPM chip power gating out of tpm_transmit()

2018-11-08 Thread Jarkko Sakkinen
On Thu, Nov 08, 2018 at 06:38:59PM +, Winkler, Tomas wrote: > > Call tpm_chip_start() and tpm_chip_stop() in > > > > * tpm_try_get_ops() and tpm_put_ops() > > * tpm_chip_register() > > * tpm2_del_space() > > > > And remove these calls from tpm_transmit(). The core reason for this change > >

Re: [PATCH v5 16/17] tpm: take TPM chip power gating out of tpm_transmit()

2018-11-08 Thread Jarkko Sakkinen
On Thu, Nov 08, 2018 at 06:38:59PM +, Winkler, Tomas wrote: > > Call tpm_chip_start() and tpm_chip_stop() in > > > > * tpm_try_get_ops() and tpm_put_ops() > > * tpm_chip_register() > > * tpm2_del_space() > > > > And remove these calls from tpm_transmit(). The core reason for this change > >

RE: [PATCH v5 16/17] tpm: take TPM chip power gating out of tpm_transmit()

2018-11-08 Thread Winkler, Tomas
> Call tpm_chip_start() and tpm_chip_stop() in > > * tpm_try_get_ops() and tpm_put_ops() > * tpm_chip_register() > * tpm2_del_space() > > And remove these calls from tpm_transmit(). The core reason for this change > is that in tpm_vtpm_proxy a locality change requires a virtual TPM command >

RE: [PATCH v5 16/17] tpm: take TPM chip power gating out of tpm_transmit()

2018-11-08 Thread Winkler, Tomas
> Call tpm_chip_start() and tpm_chip_stop() in > > * tpm_try_get_ops() and tpm_put_ops() > * tpm_chip_register() > * tpm2_del_space() > > And remove these calls from tpm_transmit(). The core reason for this change > is that in tpm_vtpm_proxy a locality change requires a virtual TPM command >