Re: [PATCH v6 1/4] cramfs: direct memory access support

On Fri, 13 Oct 2017, Nicolas Pitre wrote: > On Sat, 14 Oct 2017, Al Viro wrote: > > > On Fri, Oct 13, 2017 at 04:09:23PM -0400, Nicolas Pitre wrote: > > > On Fri, 13 Oct 2017, Al Viro wrote: > > > > > > > OK... I wonder if it should simply define stubs for kill_mtd_super(), > > > >

Re: [PATCH v6 1/4] cramfs: direct memory access support

On Fri, 13 Oct 2017, Nicolas Pitre wrote: > On Sat, 14 Oct 2017, Al Viro wrote: > > > On Fri, Oct 13, 2017 at 04:09:23PM -0400, Nicolas Pitre wrote: > > > On Fri, 13 Oct 2017, Al Viro wrote: > > > > > > > OK... I wonder if it should simply define stubs for kill_mtd_super(), > > > >

Re: [PATCH v6 1/4] cramfs: direct memory access support

On Sat, 14 Oct 2017, Al Viro wrote: > On Fri, Oct 13, 2017 at 04:09:23PM -0400, Nicolas Pitre wrote: > > On Fri, 13 Oct 2017, Al Viro wrote: > > > > > OK... I wonder if it should simply define stubs for kill_mtd_super(), > > > mtd_unpoint() and kill_block_super() in !CONFIG_MTD and

Re: [PATCH v6 1/4] cramfs: direct memory access support

On Sat, 14 Oct 2017, Al Viro wrote: > On Fri, Oct 13, 2017 at 04:09:23PM -0400, Nicolas Pitre wrote: > > On Fri, 13 Oct 2017, Al Viro wrote: > > > > > OK... I wonder if it should simply define stubs for kill_mtd_super(), > > > mtd_unpoint() and kill_block_super() in !CONFIG_MTD and

Re: [PATCH v6 1/4] cramfs: direct memory access support

On Fri, Oct 13, 2017 at 04:09:23PM -0400, Nicolas Pitre wrote: > On Fri, 13 Oct 2017, Al Viro wrote: > > > OK... I wonder if it should simply define stubs for kill_mtd_super(), > > mtd_unpoint() and kill_block_super() in !CONFIG_MTD and !CONFIG_BLOCK > > cases. mount_mtd() and mount_bdev() as

Re: [PATCH v6 1/4] cramfs: direct memory access support

On Fri, Oct 13, 2017 at 04:09:23PM -0400, Nicolas Pitre wrote: > On Fri, 13 Oct 2017, Al Viro wrote: > > > OK... I wonder if it should simply define stubs for kill_mtd_super(), > > mtd_unpoint() and kill_block_super() in !CONFIG_MTD and !CONFIG_BLOCK > > cases. mount_mtd() and mount_bdev() as

Re: [PATCH v6 1/4] cramfs: direct memory access support

On Fri, 13 Oct 2017, Al Viro wrote: > OK... I wonder if it should simply define stubs for kill_mtd_super(), > mtd_unpoint() and kill_block_super() in !CONFIG_MTD and !CONFIG_BLOCK > cases. mount_mtd() and mount_bdev() as well - e.g. mount_bdev() > returning ERR_PTR(-ENODEV) and

Re: [PATCH v6 1/4] cramfs: direct memory access support

On Fri, 13 Oct 2017, Al Viro wrote: > OK... I wonder if it should simply define stubs for kill_mtd_super(), > mtd_unpoint() and kill_block_super() in !CONFIG_MTD and !CONFIG_BLOCK > cases. mount_mtd() and mount_bdev() as well - e.g. mount_bdev() > returning ERR_PTR(-ENODEV) and

Re: [PATCH v6 1/4] cramfs: direct memory access support

On Fri, 13 Oct 2017, Al Viro wrote: > On Fri, Oct 13, 2017 at 01:39:13PM -0400, Nicolas Pitre wrote: > > On Fri, 13 Oct 2017, Al Viro wrote: > > > > > On Thu, Oct 12, 2017 at 02:16:10AM -0400, Nicolas Pitre wrote: > > > > > > > static void cramfs_kill_sb(struct super_block *sb) > > > > { > >

Re: [PATCH v6 1/4] cramfs: direct memory access support

On Fri, 13 Oct 2017, Al Viro wrote: > On Fri, Oct 13, 2017 at 01:39:13PM -0400, Nicolas Pitre wrote: > > On Fri, 13 Oct 2017, Al Viro wrote: > > > > > On Thu, Oct 12, 2017 at 02:16:10AM -0400, Nicolas Pitre wrote: > > > > > > > static void cramfs_kill_sb(struct super_block *sb) > > > > { > >

Re: [PATCH v6 1/4] cramfs: direct memory access support

On Fri, Oct 13, 2017 at 01:39:13PM -0400, Nicolas Pitre wrote: > On Fri, 13 Oct 2017, Al Viro wrote: > > > On Thu, Oct 12, 2017 at 02:16:10AM -0400, Nicolas Pitre wrote: > > > > > static void cramfs_kill_sb(struct super_block *sb) > > > { > > > struct cramfs_sb_info *sbi = CRAMFS_SB(sb); > >

Re: [PATCH v6 1/4] cramfs: direct memory access support

On Fri, Oct 13, 2017 at 01:39:13PM -0400, Nicolas Pitre wrote: > On Fri, 13 Oct 2017, Al Viro wrote: > > > On Thu, Oct 12, 2017 at 02:16:10AM -0400, Nicolas Pitre wrote: > > > > > static void cramfs_kill_sb(struct super_block *sb) > > > { > > > struct cramfs_sb_info *sbi = CRAMFS_SB(sb); > >

Re: [PATCH v6 1/4] cramfs: direct memory access support

On Fri, 13 Oct 2017, Al Viro wrote: > On Thu, Oct 12, 2017 at 02:16:10AM -0400, Nicolas Pitre wrote: > > > static void cramfs_kill_sb(struct super_block *sb) > > { > > struct cramfs_sb_info *sbi = CRAMFS_SB(sb); > > > > - kill_block_super(sb); > > + if

Re: [PATCH v6 1/4] cramfs: direct memory access support

On Fri, 13 Oct 2017, Al Viro wrote: > On Thu, Oct 12, 2017 at 02:16:10AM -0400, Nicolas Pitre wrote: > > > static void cramfs_kill_sb(struct super_block *sb) > > { > > struct cramfs_sb_info *sbi = CRAMFS_SB(sb); > > > > - kill_block_super(sb); > > + if

Re: [PATCH v6 1/4] cramfs: direct memory access support

On Thu, Oct 12, 2017 at 02:16:10AM -0400, Nicolas Pitre wrote: > static void cramfs_kill_sb(struct super_block *sb) > { > struct cramfs_sb_info *sbi = CRAMFS_SB(sb); > > - kill_block_super(sb); > + if (IS_ENABLED(CCONFIG_CRAMFS_MTD)) { > + if (sbi->mtd_point_size) >

Re: [PATCH v6 1/4] cramfs: direct memory access support

On Thu, Oct 12, 2017 at 02:16:10AM -0400, Nicolas Pitre wrote: > static void cramfs_kill_sb(struct super_block *sb) > { > struct cramfs_sb_info *sbi = CRAMFS_SB(sb); > > - kill_block_super(sb); > + if (IS_ENABLED(CCONFIG_CRAMFS_MTD)) { > + if (sbi->mtd_point_size) >

Re: [PATCH v6 1/4] cramfs: direct memory access support

This looks much better, thanks. I'm not a big fan of the games with IS_ENABLED and letting the compiler optimize code away, but you're the maintainer.. Reviewed-by: Christoph Hellwig

Re: [PATCH v6 1/4] cramfs: direct memory access support

This looks much better, thanks. I'm not a big fan of the games with IS_ENABLED and letting the compiler optimize code away, but you're the maintainer.. Reviewed-by: Christoph Hellwig

RE: [PATCH v6 1/4] cramfs: direct memory access support

On Thu, 12 Oct 2017, Chris Brandt wrote: > On Thursday, October 12, 2017, Nicolas Pitre wrote: > > Small embedded systems typically execute the kernel code in place (XIP) > > directly from flash to save on precious RAM usage. This adds the ability > > to consume filesystem data directly from

RE: [PATCH v6 1/4] cramfs: direct memory access support

On Thu, 12 Oct 2017, Chris Brandt wrote: > On Thursday, October 12, 2017, Nicolas Pitre wrote: > > Small embedded systems typically execute the kernel code in place (XIP) > > directly from flash to save on precious RAM usage. This adds the ability > > to consume filesystem data directly from

RE: [PATCH v6 1/4] cramfs: direct memory access support

On Thursday, October 12, 2017, Nicolas Pitre wrote: > Small embedded systems typically execute the kernel code in place (XIP) > directly from flash to save on precious RAM usage. This adds the ability > to consume filesystem data directly from flash to the cramfs filesystem > as well. Cramfs is

RE: [PATCH v6 1/4] cramfs: direct memory access support

On Thursday, October 12, 2017, Nicolas Pitre wrote: > Small embedded systems typically execute the kernel code in place (XIP) > directly from flash to save on precious RAM usage. This adds the ability > to consume filesystem data directly from flash to the cramfs filesystem > as well. Cramfs is