From: Joe Perches
Date: Fri, 21 Jun 2013 07:43:33 -0700
> Maybe add a Kconfig "depends on !64BIT".
Please, no.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
> So it should be declared dma_addr_t then,
>
> > + addr = dma_map_single(>dev, (void
> > *)rx_buff->skb->data,
> > + buflen, DMA_FROM_DEVICE);
> > + if (dma_mapping_error(>dev, addr)) {
> > + if
On Fri, 2013-06-21 at 17:58 +0200, Arnd Bergmann wrote:
> On Friday 21 June 2013, Joe Perches wrote:
> > On Fri, 2013-06-21 at 10:53 +, Alexey Brodkin wrote:
> > > On 06/21/2013 02:32 PM, Joe Perches wrote:
> > > > On Fri, 2013-06-21 at 11:20 +0400, Alexey Brodkin wrote:
> > > >> Driver for
On Friday 21 June 2013, Joe Perches wrote:
> On Fri, 2013-06-21 at 10:53 +, Alexey Brodkin wrote:
> > On 06/21/2013 02:32 PM, Joe Perches wrote:
> > > On Fri, 2013-06-21 at 11:20 +0400, Alexey Brodkin wrote:
> > >> Driver for non-standard on-chip ethernet device ARC EMAC 10/100,
> > >>
On Fri, 2013-06-21 at 10:53 +, Alexey Brodkin wrote:
> On 06/21/2013 02:32 PM, Joe Perches wrote:
> > On Fri, 2013-06-21 at 11:20 +0400, Alexey Brodkin wrote:
> >> Driver for non-standard on-chip ethernet device ARC EMAC 10/100,
> >> instantiated in some legacy ARC (Synopsys) FPGA Boards such
On Fri, Jun 21, 2013 at 3:25 PM, Alexey Brodkin
wrote:
> Any other comments on patch itself?
Looks fine to me.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo
On 06/21/2013 04:15 PM, Andy Shevchenko wrote:
> On Fri, Jun 21, 2013 at 1:53 PM, Alexey Brodkin
> wrote:
>
> []
>
>> But during compilation on x86 one needs to enable OF. Which will lead to
>> compilation errors in other things.
>
> JFYI, x86 has at least one platform with official OF
On Fri, Jun 21, 2013 at 1:53 PM, Alexey Brodkin
wrote:
[]
> But during compilation on x86 one needs to enable OF. Which will lead to
> compilation errors in other things.
JFYI, x86 has at least one platform with official OF dependency.
Once I actually tried to build kernel for Intel MID with
On 06/21/2013 02:32 PM, Joe Perches wrote:
> On Fri, 2013-06-21 at 11:20 +0400, Alexey Brodkin wrote:
>> Driver for non-standard on-chip ethernet device ARC EMAC 10/100,
>> instantiated in some legacy ARC (Synopsys) FPGA Boards such as
>> ARCAngel4/ML50x.
>
> Looks fine to me.
>
> One nit you
On Fri, 2013-06-21 at 11:20 +0400, Alexey Brodkin wrote:
> Driver for non-standard on-chip ethernet device ARC EMAC 10/100,
> instantiated in some legacy ARC (Synopsys) FPGA Boards such as
> ARCAngel4/ML50x.
Looks fine to me.
One nit you could fix later and a question.
> diff --git
On Fri, 2013-06-21 at 11:20 +0400, Alexey Brodkin wrote:
Driver for non-standard on-chip ethernet device ARC EMAC 10/100,
instantiated in some legacy ARC (Synopsys) FPGA Boards such as
ARCAngel4/ML50x.
Looks fine to me.
One nit you could fix later and a question.
diff --git
On 06/21/2013 02:32 PM, Joe Perches wrote:
On Fri, 2013-06-21 at 11:20 +0400, Alexey Brodkin wrote:
Driver for non-standard on-chip ethernet device ARC EMAC 10/100,
instantiated in some legacy ARC (Synopsys) FPGA Boards such as
ARCAngel4/ML50x.
Looks fine to me.
One nit you could fix later
On Fri, Jun 21, 2013 at 1:53 PM, Alexey Brodkin
alexey.brod...@synopsys.com wrote:
[]
But during compilation on x86 one needs to enable OF. Which will lead to
compilation errors in other things.
JFYI, x86 has at least one platform with official OF dependency.
Once I actually tried to build
On 06/21/2013 04:15 PM, Andy Shevchenko wrote:
On Fri, Jun 21, 2013 at 1:53 PM, Alexey Brodkin
alexey.brod...@synopsys.com wrote:
[]
But during compilation on x86 one needs to enable OF. Which will lead to
compilation errors in other things.
JFYI, x86 has at least one platform with
On Fri, Jun 21, 2013 at 3:25 PM, Alexey Brodkin
alexey.brod...@synopsys.com wrote:
Any other comments on patch itself?
Looks fine to me.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to
On Fri, 2013-06-21 at 10:53 +, Alexey Brodkin wrote:
On 06/21/2013 02:32 PM, Joe Perches wrote:
On Fri, 2013-06-21 at 11:20 +0400, Alexey Brodkin wrote:
Driver for non-standard on-chip ethernet device ARC EMAC 10/100,
instantiated in some legacy ARC (Synopsys) FPGA Boards such as
On Friday 21 June 2013, Joe Perches wrote:
On Fri, 2013-06-21 at 10:53 +, Alexey Brodkin wrote:
On 06/21/2013 02:32 PM, Joe Perches wrote:
On Fri, 2013-06-21 at 11:20 +0400, Alexey Brodkin wrote:
Driver for non-standard on-chip ethernet device ARC EMAC 10/100,
instantiated in some
On Fri, 2013-06-21 at 17:58 +0200, Arnd Bergmann wrote:
On Friday 21 June 2013, Joe Perches wrote:
On Fri, 2013-06-21 at 10:53 +, Alexey Brodkin wrote:
On 06/21/2013 02:32 PM, Joe Perches wrote:
On Fri, 2013-06-21 at 11:20 +0400, Alexey Brodkin wrote:
Driver for non-standard
So it should be declared dma_addr_t then,
+ addr = dma_map_single(ndev-dev, (void
*)rx_buff-skb-data,
+ buflen, DMA_FROM_DEVICE);
+ if (dma_mapping_error(ndev-dev, addr)) {
+ if (net_ratelimit())
From: Joe Perches j...@perches.com
Date: Fri, 21 Jun 2013 07:43:33 -0700
Maybe add a Kconfig depends on !64BIT.
Please, no.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at
20 matches
Mail list logo
