On Wed, Dec 5, 2012 at 9:30 AM, Borislav Petkov wrote:
> On Wed, Dec 05, 2012 at 04:14:14PM +, Ortiz, Lance E wrote:
>> I removed the prefix argument because it was never used by its caller
>> and never set. The reason I added the prefix variable and set it to
>> NULL was to help in breaking
On Wed, Dec 5, 2012 at 9:30 AM, Borislav Petkov b...@alien8.de wrote:
On Wed, Dec 05, 2012 at 04:14:14PM +, Ortiz, Lance E wrote:
I removed the prefix argument because it was never used by its caller
and never set. The reason I added the prefix variable and set it to
NULL was to help in
On Wed, Dec 05, 2012 at 04:14:14PM +, Ortiz, Lance E wrote:
> I removed the prefix argument because it was never used by its caller
> and never set. The reason I added the prefix variable and set it to
> NULL was to help in breaking up the patch and adding it would help the
> intermittent
> > + char *prefix = NULL;
>
> What are you doing here? You dropped the 'prefix' argument being passed
> down in this function and are defining a local variable of the same
> name
> which is used in the function later:
>
> printk("%s""aer_status: 0x%08x, aer_mask: 0x%08x\n",
>
On Tue, Dec 04, 2012 at 02:03:12PM -0700, Lance Ortiz wrote:
> This patch will provide a more reliable and easy way for user-space
> applications to have access to AER logs rather than reading them from the
> message buffer. It also provides a way to notify user-space when an AER
> event occurs.
>
On Tue, Dec 04, 2012 at 02:03:12PM -0700, Lance Ortiz wrote:
This patch will provide a more reliable and easy way for user-space
applications to have access to AER logs rather than reading them from the
message buffer. It also provides a way to notify user-space when an AER
event occurs.
+ char *prefix = NULL;
What are you doing here? You dropped the 'prefix' argument being passed
down in this function and are defining a local variable of the same
name
which is used in the function later:
printk(%saer_status: 0x%08x, aer_mask: 0x%08x\n,
prefix,
On Wed, Dec 05, 2012 at 04:14:14PM +, Ortiz, Lance E wrote:
I removed the prefix argument because it was never used by its caller
and never set. The reason I added the prefix variable and set it to
NULL was to help in breaking up the patch and adding it would help the
intermittent patch
8 matches
Mail list logo
