Re: [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data

2018-01-02 Thread Jason Gunthorpe
On Tue, Jan 02, 2018 at 05:31:30AM +, Shaikh, Azhar wrote: > >>On Mon, Jan 01, 2018 at 08:05:43PM -0800, Azhar Shaikh wrote: > >> > >>> - return tpm_chip_register(chip); > >>> + rc = tpm_chip_register(chip); > >>> + if (rc && is_bsw()) > >>> + iounmap(priv->ilb_base_addr); > >>> + >

Re: [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data

2018-01-02 Thread Jason Gunthorpe
On Tue, Jan 02, 2018 at 05:31:30AM +, Shaikh, Azhar wrote: > >>On Mon, Jan 01, 2018 at 08:05:43PM -0800, Azhar Shaikh wrote: > >> > >>> - return tpm_chip_register(chip); > >>> + rc = tpm_chip_register(chip); > >>> + if (rc && is_bsw()) > >>> + iounmap(priv->ilb_base_addr); > >>> + >

RE: [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data

2018-01-01 Thread Shaikh, Azhar
.@gmx.de; linux-security- >mod...@vger.kernel.org; linux-integr...@vger.kernel.org; linux- >ker...@vger.kernel.org >Subject: RE: [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data > > > >>-Original Message- >>From: Jason Gunthorpe [mailto:j...@ziepe.ca

RE: [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data

2018-01-01 Thread Shaikh, Azhar
nux-security- >mod...@vger.kernel.org; linux-integr...@vger.kernel.org; linux- >ker...@vger.kernel.org >Subject: RE: [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data > > > >>-Original Message- >>From: Jason Gunthorpe [mailto:j...@ziepe.ca] >>Sent: Mon

RE: [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data

2018-01-01 Thread Shaikh, Azhar
.@vger.kernel.org; linux- >ker...@vger.kernel.org >Subject: Re: [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data > >On Mon, Jan 01, 2018 at 08:05:43PM -0800, Azhar Shaikh wrote: > >> -return tpm_chip_register(chip); >> +rc = tpm_chip_register(chip); >&

RE: [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data

2018-01-01 Thread Shaikh, Azhar
er...@vger.kernel.org >Subject: Re: [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data > >On Mon, Jan 01, 2018 at 08:05:43PM -0800, Azhar Shaikh wrote: > >> -return tpm_chip_register(chip); >> +rc = tpm_chip_register(chip); >> +if (rc &

Re: [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data

2018-01-01 Thread Jason Gunthorpe
On Mon, Jan 01, 2018 at 08:05:43PM -0800, Azhar Shaikh wrote: > - return tpm_chip_register(chip); > + rc = tpm_chip_register(chip); > + if (rc && is_bsw()) > + iounmap(priv->ilb_base_addr); > + > + return rc; > out_err: > tpm_tis_remove(chip); > + if

Re: [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data

2018-01-01 Thread Jason Gunthorpe
On Mon, Jan 01, 2018 at 08:05:43PM -0800, Azhar Shaikh wrote: > - return tpm_chip_register(chip); > + rc = tpm_chip_register(chip); > + if (rc && is_bsw()) > + iounmap(priv->ilb_base_addr); > + > + return rc; > out_err: > tpm_tis_remove(chip); > + if