> From: Scott Wood
> Maybe that's how it was, but the current code initializes it (more or
> less) directly with IMAP_ADDR, which also gets fed into ioremap.
>
> One of the two has got to be wrong.
arch/ppc maps the immr area 1:1 into kernel memory, so ioremap and
physical are the same.
See
On Wed, Sep 26, 2007 at 03:32:29PM -0500, Rune Torgersen wrote:
> > From: Scott Wood
> > Maybe that's how it was, but the current code initializes it (more or
> > less) directly with IMAP_ADDR, which also gets fed into ioremap.
> >
> > One of the two has got to be wrong.
>
> arch/ppc maps the
On Wed, Sep 26, 2007 at 03:32:29PM -0500, Rune Torgersen wrote:
From: Scott Wood
Maybe that's how it was, but the current code initializes it (more or
less) directly with IMAP_ADDR, which also gets fed into ioremap.
One of the two has got to be wrong.
arch/ppc maps the immr area 1:1
From: Scott Wood
Maybe that's how it was, but the current code initializes it (more or
less) directly with IMAP_ADDR, which also gets fed into ioremap.
One of the two has got to be wrong.
arch/ppc maps the immr area 1:1 into kernel memory, so ioremap and
physical are the same.
See
On Tue, Sep 25, 2007 at 02:09:03PM +0200, Jochen Friedrich wrote:
> In cpm_uart_core.c, the operation "pinfo->rx_bd_base - DPRAM_BASE" is
> used to calculate the DPRAM offset. So DPRAM_BASE must be relative to
> dpram_vbase in commproc.c as well. However, cpm_uart_cpm1.h uses cpmp in
>
Hi Scott,
Yikes. Please don't change cpm_uart_cpm1.h, as it's correct for
arch/powerpc, and there are numerous other places that assume cpmp is
virtual (including in the very same function that assigns it a
physical address).
I'm still not convinced cpm_uart_cpm1.h is correct:
Hi Scott,
Yikes. Please don't change cpm_uart_cpm1.h, as it's correct for
arch/powerpc, and there are numerous other places that assume cpmp is
virtual (including in the very same function that assigns it a
physical address).
I'm still not convinced cpm_uart_cpm1.h is correct:
On Tue, Sep 25, 2007 at 02:09:03PM +0200, Jochen Friedrich wrote:
In cpm_uart_core.c, the operation pinfo-rx_bd_base - DPRAM_BASE is
used to calculate the DPRAM offset. So DPRAM_BASE must be relative to
dpram_vbase in commproc.c as well. However, cpm_uart_cpm1.h uses cpmp in
commproc.c to
Dan Malek wrote:
On Sep 24, 2007, at 11:22 AM, Scott Wood wrote:
cpmp is a physical address on arch/ppc?
No, it's a well known ioremaped() address into the IMMR space.
Maybe that's how it was, but the current code initializes it (more or
less) directly with IMAP_ADDR, which also gets fed
On Sep 24, 2007, at 11:22 AM, Scott Wood wrote:
cpmp is a physical address on arch/ppc?
No, it's a well known ioremaped() address
into the IMMR space. The only physical
addresses in any of the CPM/CPM2 are
those required to by the buffer descriptors.
There are DPRAM offsets, but they should
Jochen Friedrich wrote:
Scott Wood schrieb:
Jochen Friedrich wrote:
In cpm_uart_core, functions cpm_uart_init_bd and cpm_uart_init_scc
an offset into DP RAM is calculated by substracting a physical
memory constant from an virtual address. This patch fixes the
problem by converting the virtual
Scott Wood schrieb:
Jochen Friedrich wrote:
In cpm_uart_core, functions cpm_uart_init_bd and cpm_uart_init_scc
an offset into DP RAM is calculated by substracting a physical
memory constant from an virtual address. This patch fixes the
problem by converting the virtual address into a physical
Jochen Friedrich wrote:
In cpm_uart_core, functions cpm_uart_init_bd and cpm_uart_init_scc
an offset into DP RAM is calculated by substracting a physical
memory constant from an virtual address. This patch fixes the
problem by converting the virtual address into a physical
first.
Huh?
Jochen Friedrich wrote:
In cpm_uart_core, functions cpm_uart_init_bd and cpm_uart_init_scc
an offset into DP RAM is calculated by substracting a physical
memory constant from an virtual address. This patch fixes the
problem by converting the virtual address into a physical
first.
Huh?
Scott Wood schrieb:
Jochen Friedrich wrote:
In cpm_uart_core, functions cpm_uart_init_bd and cpm_uart_init_scc
an offset into DP RAM is calculated by substracting a physical
memory constant from an virtual address. This patch fixes the
problem by converting the virtual address into a physical
Jochen Friedrich wrote:
Scott Wood schrieb:
Jochen Friedrich wrote:
In cpm_uart_core, functions cpm_uart_init_bd and cpm_uart_init_scc
an offset into DP RAM is calculated by substracting a physical
memory constant from an virtual address. This patch fixes the
problem by converting the virtual
On Sep 24, 2007, at 11:22 AM, Scott Wood wrote:
cpmp is a physical address on arch/ppc?
No, it's a well known ioremaped() address
into the IMMR space. The only physical
addresses in any of the CPM/CPM2 are
those required to by the buffer descriptors.
There are DPRAM offsets, but they should
Dan Malek wrote:
On Sep 24, 2007, at 11:22 AM, Scott Wood wrote:
cpmp is a physical address on arch/ppc?
No, it's a well known ioremaped() address into the IMMR space.
Maybe that's how it was, but the current code initializes it (more or
less) directly with IMAP_ADDR, which also gets fed
18 matches
Mail list logo
