Re: [RFC PATCH v12 10/11] arm64: add mechanism to let user choose which counter to return

2020-05-25 Thread Marc Zyngier
: add mechanism to let user choose which counter to return On 2020-05-24 03:11, Richard Cochran wrote: > On Fri, May 22, 2020 at 04:37:23PM +0800, Jianyong Wu wrote: >> In general, vm inside will use virtual counter compered with host use >> phyical counter. But in some special scenari

RE: [RFC PATCH v12 10/11] arm64: add mechanism to let user choose which counter to return

2020-05-25 Thread Jianyong Wu
...@intel.com; > Mark Rutland ; w...@kernel.org; Suzuki Poulose > ; Steven Price ; linux- > ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > kvm...@lists.cs.columbia.edu; k...@vger.kernel.org; Steve Capper > ; Kaly Xin ; Justin He > ; Wei Chen ; nd > Subject: Re:

Re: [RFC PATCH v12 10/11] arm64: add mechanism to let user choose which counter to return

2020-05-25 Thread Marc Zyngier
On 2020-05-24 03:11, Richard Cochran wrote: On Fri, May 22, 2020 at 04:37:23PM +0800, Jianyong Wu wrote: In general, vm inside will use virtual counter compered with host use phyical counter. But in some special scenarios, like nested virtualization, phyical counter maybe used by vm. A

RE: [RFC PATCH v12 10/11] arm64: add mechanism to let user choose which counter to return

2020-05-25 Thread Jianyong Wu
er...@intel.com; Mark Rutland ; > w...@kernel.org; Suzuki Poulose ; Steven Price > ; linux-kernel@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; kvm...@lists.cs.columbia.edu; > k...@vger.kernel.org; Steve Capper ; Kaly Xin > ; Justin He ; Wei Chen > ; nd > Subject: Re:

Re: [RFC PATCH v12 10/11] arm64: add mechanism to let user choose which counter to return

2020-05-25 Thread Richard Cochran
On Mon, May 25, 2020 at 04:50:28AM +, Jianyong Wu wrote: > How about adding an extra argument in struct ptp_clock_info to serve as a > flag, then we can control this flag using IOCTL to determine the counter type. no, No, NO! > > From your description, this "flag" really should be a module

RE: [RFC PATCH v12 10/11] arm64: add mechanism to let user choose which counter to return

2020-05-24 Thread Jianyong Wu
m...@kernel.org; Mark Rutland ; w...@kernel.org; > Suzuki Poulose ; Steven Price > ; linux-kernel@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; kvm...@lists.cs.columbia.edu; > k...@vger.kernel.org; Steve Capper ; Kaly Xin > ; Justin He ; Wei Chen > ; nd > Sub

Re: [RFC PATCH v12 10/11] arm64: add mechanism to let user choose which counter to return

2020-05-23 Thread Richard Cochran
On Fri, May 22, 2020 at 04:37:23PM +0800, Jianyong Wu wrote: > In general, vm inside will use virtual counter compered with host use > phyical counter. But in some special scenarios, like nested > virtualization, phyical counter maybe used by vm. A interface added in > ptp_kvm driver to offer a

Re: [RFC PATCH v12 10/11] arm64: add mechanism to let user choose which counter to return

2020-05-23 Thread Richard Cochran
On Fri, May 22, 2020 at 04:37:23PM +0800, Jianyong Wu wrote: > To use this feature, you should call PTP_EXTTS_REQUEST(2) ioctl with flag > set bit PTP_KVM_ARM_PHY_COUNTER in its argument then call > PTP_SYS_OFFSET_PRECISE(2) ioctl to get the cross timestamp and phyical > counter will return. If