RE: [RFC PATCH v2 08/15] usb:cdns3: Implements device operations part of the API

2018-12-16 Thread Pawel Laszczak
Hi > >On 14/12/18 4:56 PM, Felipe Balbi wrote: >> Hi, >> >> Sekhar Nori writes: All this should be part of comments in code along with information about controller versions which suffer from the errata. Is there a version of controller available

Re: [RFC PATCH v2 08/15] usb:cdns3: Implements device operations part of the API

2018-12-14 Thread Felipe Balbi
Hi, Sekhar Nori writes: > especially since you already know there is going to be another revision > of hardware. It has the advantage that one can easily grep to see which > hardware is running current version of controller without having access > to the hardware itself. Becomes

Re: [RFC PATCH v2 08/15] usb:cdns3: Implements device operations part of the API

2018-12-14 Thread Sekhar Nori
On 14/12/18 4:56 PM, Felipe Balbi wrote: > Hi, > > Sekhar Nori writes: >>> All this should be part of comments in code along with information about >>> controller versions which suffer from the errata. >>> >>> Is there a version of controller available which does not have the

Re: [RFC PATCH v2 08/15] usb:cdns3: Implements device operations part of the API

2018-12-14 Thread Felipe Balbi
Hi, Sekhar Nori writes: >> All this should be part of comments in code along with information about >> controller versions which suffer from the errata. >> >> Is there a version of controller available which does not have the >> defect? Is there a future plan to fix this?

Re: [RFC PATCH v2 08/15] usb:cdns3: Implements device operations part of the API

2018-12-14 Thread Sekhar Nori
Hi Felipe, On 14/12/18 4:17 PM, Felipe Balbi wrote: > Hi, > > Sekhar Nori writes: > > > > All this should be part of comments in code along with information about > controller versions which suffer from the errata. > > Is there a version of controller available which does not

Re: [RFC PATCH v2 08/15] usb:cdns3: Implements device operations part of the API

2018-12-14 Thread Felipe Balbi
Hi, Sekhar Nori writes: All this should be part of comments in code along with information about controller versions which suffer from the errata. Is there a version of controller available which does not have the defect? Is there a future plan to fix this?

Re: [RFC PATCH v2 08/15] usb:cdns3: Implements device operations part of the API

2018-12-14 Thread Sekhar Nori
On 14/12/18 7:04 AM, Peter Chen wrote: > On Wed, Dec 12, 2018 at 3:49 AM Pawel Laszczak wrote: >> >> Hi, >> >>> On 10/12/18 7:42 AM, Peter Chen wrote: >> +static struct usb_ep *cdns3_gadget_match_ep(struct usb_gadget *gadget, >> + struct

RE: [RFC PATCH v2 08/15] usb:cdns3: Implements device operations part of the API

2018-12-13 Thread Pawel Laszczak
Hi, > >On Wed, Dec 12, 2018 at 3:49 AM Pawel Laszczak wrote: >> >> Hi, >> >> >On 10/12/18 7:42 AM, Peter Chen wrote: >> +static struct usb_ep *cdns3_gadget_match_ep(struct usb_gadget *gadget, >> + struct >> usb_endpoint_descriptor *desc, >>

Re: [RFC PATCH v2 08/15] usb:cdns3: Implements device operations part of the API

2018-12-13 Thread Peter Chen
On Wed, Dec 12, 2018 at 3:49 AM Pawel Laszczak wrote: > > Hi, > > >On 10/12/18 7:42 AM, Peter Chen wrote: > +static struct usb_ep *cdns3_gadget_match_ep(struct usb_gadget *gadget, > + struct usb_endpoint_descriptor > *desc, > +

RE: [RFC PATCH v2 08/15] usb:cdns3: Implements device operations part of the API

2018-12-11 Thread Pawel Laszczak
Hi, >On 10/12/18 7:42 AM, Peter Chen wrote: +static struct usb_ep *cdns3_gadget_match_ep(struct usb_gadget *gadget, + struct usb_endpoint_descriptor *desc, + struct usb_ss_ep_comp_descriptor

Re: [RFC PATCH v2 08/15] usb:cdns3: Implements device operations part of the API

2018-12-11 Thread Sekhar Nori
On 10/12/18 7:42 AM, Peter Chen wrote: >>> +static struct usb_ep *cdns3_gadget_match_ep(struct usb_gadget *gadget, >>> + struct usb_endpoint_descriptor >>> *desc, >>> + struct usb_ss_ep_comp_descriptor >>>

Re: [RFC PATCH v2 08/15] usb:cdns3: Implements device operations part of the API

2018-12-09 Thread Peter Chen
> > +static struct cdns3_endpoint *cdns3_find_available_ss_ep(struct > > cdns3_device *priv_dev, > > + struct > > usb_endpoint_descriptor *desc) > > why is this function called ss_ep? This doesn't seem like only for superspeed > endpoints. >