RE: [RFC PATCH v3 2/2] net: phy: Add gmiitorgmii converter support

2016-08-05 Thread Appana Durga Kedareswara Rao
Hi zhuyj, Thanks for the review... > > + switch (phydev->speed) { > + case SPEED_1000: > + val |= BMCR_SPEED1000; > + case SPEED_100: > + val |= BMCR_SPEED100; > + } > > Are there only 2 kinds of speed? Converter supports 3 different

RE: [RFC PATCH v3 2/2] net: phy: Add gmiitorgmii converter support

2016-08-05 Thread Appana Durga Kedareswara Rao
Hi zhuyj, Thanks for the review... > > + switch (phydev->speed) { > + case SPEED_1000: > + val |= BMCR_SPEED1000; > + case SPEED_100: > + val |= BMCR_SPEED100; > + } > > Are there only 2 kinds of speed? Converter supports 3 different

Re: [RFC PATCH v3 2/2] net: phy: Add gmiitorgmii converter support

2016-08-05 Thread zhuyj
+ switch (phydev->speed) { + case SPEED_1000: + val |= BMCR_SPEED1000; + case SPEED_100: + val |= BMCR_SPEED100; + } Are there only 2 kinds of speed? On Thu, Aug 4, 2016 at 8:13 PM, Kedareswara rao Appana wrote: >

Re: [RFC PATCH v3 2/2] net: phy: Add gmiitorgmii converter support

2016-08-05 Thread zhuyj
+ switch (phydev->speed) { + case SPEED_1000: + val |= BMCR_SPEED1000; + case SPEED_100: + val |= BMCR_SPEED100; + } Are there only 2 kinds of speed? On Thu, Aug 4, 2016 at 8:13 PM, Kedareswara rao Appana wrote: > This patch adds support for