Re: [RFC net-next] treewide: s/ipv4_is_()/ipv4_addr_/

2012-10-11 Thread Joe Perches
On Thu, 2012-10-11 at 09:11 +0100, David Laight wrote: > > ipv4 and ipv6 use different styles for these tests. > > > > ipv4_is_(__be32) > > ipv6_addr_(struct in6_addr *) > > I presume there is a 'const' in there ... > > > Perhaps it'd be good to convert the ipv4 tests to the ipv6 style. > > You

RE: [RFC net-next] treewide: s/ipv4_is_()/ipv4_addr_/

2012-10-11 Thread David Laight
> ipv4 and ipv6 use different styles for these tests. > > ipv4_is_(__be32) > ipv6_addr_(struct in6_addr *) I presume there is a 'const' in there ... > Perhaps it'd be good to convert the ipv4 tests to the ipv6 style. You don't want to force an IPv4 address (which might be in a register) be writ