RE: [char-misc-next 01/11] mei: bus: Initial MEI bus type implementation

2013-02-07 Thread Winkler, Tomas
> -Original Message- > From: Samuel Ortiz [mailto:sa...@linux.intel.com] > Sent: Friday, February 08, 2013 00:59 > To: Arnd Bergmann > Cc: Winkler, Tomas; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org > Subject: Re: [char-misc-next 01/11] mei: bus:

Re: [char-misc-next 01/11] mei: bus: Initial MEI bus type implementation

2013-02-07 Thread Samuel Ortiz
On Thu, Feb 07, 2013 at 10:41:06PM +, Arnd Bergmann wrote: > On Thursday 07 February 2013, Tomas Winkler wrote: > > +} > > +EXPORT_SYMBOL(mei_add_device); > > + > > +void mei_remove_device(struct mei_bus_client *client) > > +{ > > + device_unregister(&client->dev); > > +} > > +EXPORT_SYMB

Re: [char-misc-next 01/11] mei: bus: Initial MEI bus type implementation

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Tomas Winkler wrote: > +} > +EXPORT_SYMBOL(mei_add_device); > + > +void mei_remove_device(struct mei_bus_client *client) > +{ > + device_unregister(&client->dev); > +} > +EXPORT_SYMBOL(mei_remove_device); One more point: did you intentionally pick EXPORT_SYMBOL

Re: [char-misc-next 01/11] mei: bus: Initial MEI bus type implementation

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, Tomas Winkler wrote: > From: Samuel Ortiz > > mei bus will present some of the me clients > as devices for other standard subsystems > > Implement the probe, remove, match and the device addtion routines. > A mei-bus.txt document describing the rationale and the API