RE: [patch v8 1/1] i2c: add master driver for mellanox systems

2016-11-20 Thread Vadim Pasternak
> Subject: Re: [patch v8 1/1] i2c: add master driver for mellanox systems > > > > Possibly I should add validation for "num" parameter at the beginning of > mlxcpld_i2c_xfer? > > There is 'max_num_msgs' in the quirk structure. Yes, I see it. S

Re: [patch v8 1/1] i2c: add master driver for mellanox systems

2016-11-20 Thread Wolfram Sang
> Possibly I should add validation for "num" parameter at the beginning of > mlxcpld_i2c_xfer? There is 'max_num_msgs' in the quirk structure. Thanks, Wolfram signature.asc Description: PGP signature

RE: [patch v8 1/1] i2c: add master driver for mellanox systems

2016-11-19 Thread Vadim Pasternak
.us; Michael Shych > > Subject: Re: [patch v8 1/1] i2c: add master driver for mellanox systems > > Hi, > > looks mostly good. I just found this comment which needs clarification: > > > + /* > > +* All upper layers currently are never use transfer with more than > &g

Re: [patch v8 1/1] i2c: add master driver for mellanox systems

2016-11-19 Thread Wolfram Sang
Hi, looks mostly good. I just found this comment which needs clarification: > + /* > + * All upper layers currently are never use transfer with more than > + * 2 messages. Have you really checked ALL of the upper layers? And even if so, there is the dev-interface to userspace which