RE: [v2 PATCH 1/3] panic: Change nmi_panic from macro to function

2016-03-02 Thread 河合英宏 / KAWAI，HIDEHIRO
Hi, > From: Borislav Petkov [mailto:b...@alien8.de] > On Wed, Mar 02, 2016 at 02:18:24PM +0100, Michal Hocko wrote: > > On Wed 02-03-16 19:36:26, Hidehiro Kawai wrote: > > [...] > > > +void nmi_panic(struct pt_regs *regs, const char *fmt, ...) > > > > Do we really need vargs? All the current

RE: [v2 PATCH 1/3] panic: Change nmi_panic from macro to function

2016-03-02 Thread 河合英宏 / KAWAI，HIDEHIRO
Hi, > From: Borislav Petkov [mailto:b...@alien8.de] > On Wed, Mar 02, 2016 at 02:18:24PM +0100, Michal Hocko wrote: > > On Wed 02-03-16 19:36:26, Hidehiro Kawai wrote: > > [...] > > > +void nmi_panic(struct pt_regs *regs, const char *fmt, ...) > > > > Do we really need vargs? All the current

Re: [v2 PATCH 1/3] panic: Change nmi_panic from macro to function

2016-03-02 Thread Guenter Roeck
On 03/02/2016 05:18 AM, Michal Hocko wrote: On Wed 02-03-16 19:36:26, Hidehiro Kawai wrote: [...] +void nmi_panic(struct pt_regs *regs, const char *fmt, ...) Do we really need vargs? All the current users seem to be OK with a simple string. This makes the code slightly more complicated

Re: [v2 PATCH 1/3] panic: Change nmi_panic from macro to function

2016-03-02 Thread Guenter Roeck
On 03/02/2016 05:18 AM, Michal Hocko wrote: On Wed 02-03-16 19:36:26, Hidehiro Kawai wrote: [...] +void nmi_panic(struct pt_regs *regs, const char *fmt, ...) Do we really need vargs? All the current users seem to be OK with a simple string. This makes the code slightly more complicated

Re: [v2 PATCH 1/3] panic: Change nmi_panic from macro to function

2016-03-02 Thread Borislav Petkov
On Wed, Mar 02, 2016 at 02:18:24PM +0100, Michal Hocko wrote: > On Wed 02-03-16 19:36:26, Hidehiro Kawai wrote: > [...] > > +void nmi_panic(struct pt_regs *regs, const char *fmt, ...) > > Do we really need vargs? All the current users seem to be OK with a > simple string. This makes the code

Re: [v2 PATCH 1/3] panic: Change nmi_panic from macro to function

2016-03-02 Thread Borislav Petkov
On Wed, Mar 02, 2016 at 02:18:24PM +0100, Michal Hocko wrote: > On Wed 02-03-16 19:36:26, Hidehiro Kawai wrote: > [...] > > +void nmi_panic(struct pt_regs *regs, const char *fmt, ...) > > Do we really need vargs? All the current users seem to be OK with a > simple string. This makes the code

Re: [v2 PATCH 1/3] panic: Change nmi_panic from macro to function

2016-03-02 Thread Michal Hocko
On Wed 02-03-16 19:36:26, Hidehiro Kawai wrote: [...] > +void nmi_panic(struct pt_regs *regs, const char *fmt, ...) Do we really need vargs? All the current users seem to be OK with a simple string. This makes the code slightly more complicated without any apparent reason. > +{ > + static

Re: [v2 PATCH 1/3] panic: Change nmi_panic from macro to function

2016-03-02 Thread Michal Hocko
On Wed 02-03-16 19:36:26, Hidehiro Kawai wrote: [...] > +void nmi_panic(struct pt_regs *regs, const char *fmt, ...) Do we really need vargs? All the current users seem to be OK with a simple string. This makes the code slightly more complicated without any apparent reason. > +{ > + static